search

LibreHealthIO / lh-ehr

LibreHealth EHR - Free Open Source Electronic Health Records
Other
238 stars 262 forks source link

Inappropriate Module Name on Tab Control #1459

Open Meghana122 opened 5 years ago

Meghana122 commented 5 years ago

A) Outreachy Username: meghana

B) Issue title: Inappropriate module name.

C) Report Date: March 21, 2019

D) Sites Affected: Both Documentation and NHANES sites.

E) Browsers used: Microsoft Edge and Google Chrome on Windows 10.

F) EHR Workflow module: Miscellaneous => Portal Dashboard, there click on the “Mail” button.

G) Steps to Reproduce the Issue:
1) Login to the LibreHealth documentation site with your login credentials. 2) On the main screen, under “Miscellaneous” click on “Portal Dashboard”. 3) In Portal Dashboard module, you will find a “Mail” button, click on that.

H) Expected Behavior: The Module name should be appropriate and related to Mail.

I) What Actually Happened: The Module name was “1”, which is inappropriate, for a module related to Mail.

J) Screenshots with Explanation:
1) The module name is “1”, as shown in the highlighted portion.

WrongModuleName

2) But the module is related to Mail, and the name related to mailing can be considered appropriate.

K) Estimation of Severity: Workflow does not get disturbed but it may confuse the user(Minor).

M) Suggested Solution:
The most possible solution can be, changing the name of the module according to the function which the module performs. In this case, the module name can be changed to “Patient Mail” from “1”.

AppropriateName

muarachmann commented 5 years ago

Nice one there, quick fix for this would be appreciated. You've got this @Meghana122

Meghana122 commented 5 years ago

Thank you.

Meghana122 commented 5 years ago

@muarachmann I have tried finding the correct file to fix the issue, but I couldn't. Please could you suggest a way to figure that out.

muarachmann commented 5 years ago

@Meghana122 right click on the frame and chose view frame source code. I am sure you will have your answers :)

Meghana122 commented 5 years ago

Thank you for helping me with that.

aethelwulffe commented 5 years ago

I added the general fix for this to a new repo wiki page. @muarachmann tell me what you think https://github.com/LibreHealthIO/lh-ehr/wiki/Developer-Blog

aethelwulffe commented 5 years ago

This is within the patient portal administration. That should help a bit. Searching for the string "Patient Messaging" will also help find the script.

aethelwulffe commented 5 years ago

/patient_portal directory.

aethelwulffe commented 5 years ago

This is Patient Portal Messaging... In reality, if it is opening in an isolated tab, then Patient Portal is a good label. This is a very distinct feature from the interoffice communication.