search

LibreHealthIO / lh-ehr

LibreHealth EHR - Free Open Source Electronic Health Records
Other
241 stars 264 forks source link

A fix inappropriate module name #1611

Open ahanipeitra1994 opened 4 years ago

ahanipeitra1994 commented 4 years ago

I did a fix on the issue #1459. image

muarachmann commented 4 years ago

Can you remove the other secure message below? sounds redundant

Screen Shot 2020-06-10 at 4 04 41 AM
ahanipeitra1994 commented 4 years ago

Ok i will remove that

On Wed, 10 Jun 2020 at 04:05, muarachmann notifications@github.com wrote:

Can you remove the other secure message below? sounds redundant [image: Screen Shot 2020-06-10 at 4 04 41 AM] https://user-images.githubusercontent.com/16350814/84222491-a025b780-aacf-11ea-9623-b5bd33ed21ee.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/pull/1611#issuecomment-641691926, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQABPACXBQRXCLDOZVSATDRV32AZANCNFSM4NIZQZOA .

maggienegm commented 4 years ago

@ahanipeitra1994 By default, the tab title shows within the tab, which is why "Secure Message" shows underneath the tab title. Since the module already has a name ("Patient Messaging"), I would make that the title and move that piece of code up into where you added a title, so the tab name will become "Patient Messaging" and logo + title within the tab will display the way it's currently being displayed.

Ngai-E commented 4 years ago

Works fine now. @maggienegm the previous format is kind of obsolete with majority of the web using HTML5. content-type was used to specify character encoding but now we can just use this <meta charset="utf-8"> directly. Thanks for taking out time to refactor the code base as well @ahanipeitra1994, delete the comment.

maggienegm commented 4 years ago

Tested and LGTM. @Ngai-E and @muarachmann ?

ahanipeitra1994 commented 4 years ago

Ok thanks I will change it

On Sat, Sep 5, 2020, 9:46 AM Mua Rachmann notifications@github.com wrote:

@muarachmann commented on this pull request.

In patient_portal/messaging/messages.php https://github.com/LibreHealthIO/lh-ehr/pull/1611#discussion_r483928611:

@@ -111,6 +110,9 @@ function getAuthPortalUsers()

+
+

/logo-full-con.png'/>

+
I think it should be patient portal — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or unsubscribe .