LibreHealthIO / lh-ehr

LibreHealth EHR - Free Open Source Electronic Health Records
Other
234 stars 258 forks source link

Review OpenEMR DevTip for good stuff #2

Closed tmccormi closed 8 years ago

tmccormi commented 8 years ago

Review and Cherry-Pick elements of @openemr that pass muster with the team for inclusion in the 1.0 release

tmccormi commented 8 years ago

This looks likely to cherry-pick:

SF Thread: https://mail.google.com/mail/u/0/#inbox/156305b953ab5e25

teryhill commented 8 years ago

I got it and will commit it later

  From: Tony McCormick <notifications@github.com>

To: LibreEHR/LibreEHR LibreEHR@noreply.github.com Sent: Thursday, July 28, 2016 1:39 PM Subject: Re: [LibreEHR/LibreEHR] Review OpenEMR DevTip for good stuff (#2)

This looks likely to cherry-pick: https://mail.google.com/mail/u/0/#inbox/156305b953ab5e25 openemr/openemr#164 You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

aethelwulffe commented 8 years ago

OK, for those of us not on that thread, what are these validation checks for?

On 2016-07-28 01:44 PM, Terry Hill wrote:

I got it and will commit it later

From: Tony McCormick notifications@github.com To: LibreEHR/LibreEHR LibreEHR@noreply.github.com Sent: Thursday, July 28, 2016 1:39 PM Subject: Re: [LibreEHR/LibreEHR] Review OpenEMR DevTip for good stuff (#2)

This looks likely to cherry-pick: https://mail.google.com/mail/u/0/#inbox/156305b953ab5e25 openemr/openemr#164— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235970329, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhzFy6Rda4SK_tR-dzMuk-BPnFIgXhbks5qaOqLgaJpZM4JN2s1.

tmccormi commented 8 years ago

Just click on the pull request and read it ... if reading the SF thread is against your religion :-)

On Thu, Jul 28, 2016 at 10:48 AM, Art Eaton notifications@github.com wrote:

OK, for those of us not on that thread, what are these validation checks for?

On 2016-07-28 01:44 PM, Terry Hill wrote:

I got it and will commit it later

From: Tony McCormick notifications@github.com To: LibreEHR/LibreEHR LibreEHR@noreply.github.com Sent: Thursday, July 28, 2016 1:39 PM Subject: Re: [LibreEHR/LibreEHR] Review OpenEMR DevTip for good stuff (#2)

This looks likely to cherry-pick: https://mail.google.com/mail/u/0/#inbox/156305b953ab5e25 openemr/openemr#164— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235970329, or mute the thread < https://github.com/notifications/unsubscribe-auth/AAhzFy6Rda4SK_tR-dzMuk-BPnFIgXhbks5qaOqLgaJpZM4JN2s1 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235971518, or mute the thread https://github.com/notifications/unsubscribe-auth/AARci0siQWeuUOB3MYXVGJur0W1HRogGks5qaOt5gaJpZM4JN2s1 .

Please be aware that e-mail communication can be intercepted in transmission or misdirected. Please consider communicating any sensitive information by telephone. The information contained in this message may be privileged and confidential. If you are NOT the intended recipient, please notify the sender immediately with a copy to hipaa-security@mrsb-ltd.com and destroy this message.

aethelwulffe commented 8 years ago

No, the link to the thread just isn't working for me. I tried a few times.

On 2016-07-28 01:52 PM, Tony McCormick wrote:

Just click on the pull request and read it ... if reading the SF thread is against your religion :-)

Tony McCormick, CTO www.mi-squared.com Support: 866-735-0897, Direct: 713-574-6709 My Calendar: http://bit.ly/XznvDo "Genuinely evolved interfaces are transparent, so transparent as to be invisible" - William Gibson

On Thu, Jul 28, 2016 at 10:48 AM, Art Eaton notifications@github.com wrote:

OK, for those of us not on that thread, what are these validation checks for?

On 2016-07-28 01:44 PM, Terry Hill wrote:

I got it and will commit it later

From: Tony McCormick notifications@github.com To: LibreEHR/LibreEHR LibreEHR@noreply.github.com Sent: Thursday, July 28, 2016 1:39 PM Subject: Re: [LibreEHR/LibreEHR] Review OpenEMR DevTip for good stuff (#2)

This looks likely to cherry-pick: https://mail.google.com/mail/u/0/#inbox/156305b953ab5e25 openemr/openemr#164— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub

https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235970329, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AAhzFy6Rda4SK_tR-dzMuk-BPnFIgXhbks5qaOqLgaJpZM4JN2s1

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235971518, or mute the thread

https://github.com/notifications/unsubscribe-auth/AARci0siQWeuUOB3MYXVGJur0W1HRogGks5qaOt5gaJpZM4JN2s1 .

Please be aware that e-mail communication can be intercepted in transmission or misdirected. Please consider communicating any sensitive information by telephone. The information contained in this message may be privileged and confidential. If you are NOT the intended recipient, please notify the sender immediately with a copy to hipaa-security@mrsb-ltd.com and destroy this message.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235972748, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhzFwqDH76wyCw93KjBaH2AVopu_Vgpks5qaOx4gaJpZM4JN2s1.

teryhill commented 8 years ago

Here is the comment This feature should upgrade the page forms validation in all of the openemr system to use validate.js library.The purpose was to add the ability to validate pages forms and fields in the system using the list_options table and use it all around the forms in the openemr in a little of customization and code writing.in these branch we did the implementation in the add_edit_issue.php form.In order to use this feature first you will need to create a new page validation under administration->lists there under The PageValidation list add using the validate.js library validation format add the new fields validations.below is an example for two fields form_title and form_diagnosis in add_edit_issue.php that needs to be validated on submit.ID = add_edit_issue //this is the id of the record in the database TITLE = add_edit_issue.php //this is the page file in the system Active = 0/1 Notes = {form_title:{presence: true},form_diagnosis:{presence: true}} //this is the page formatAfter creating this record Globals.php will collect all the pages that need to be validated. all that left is to go in the page needed and like in add_edit_issue.php validate these fields using  the submitme function that is implemented in the  /home/drorgo/projects/openemrValidation/openemr/library/validation/validation_script.js.phpfile..****8 To have backward compatibility when adding these feature in other forms ,the actual hardcoded validation rules should be translated to the new validate.js rules and inserted to lists using the steps I have mentioned above. Try this https://github.com/openemr/openemr/pull/164

  From: Art Eaton <notifications@github.com>

To: LibreEHR/LibreEHR LibreEHR@noreply.github.com Cc: Terry Hill teryhill@yahoo.com; Comment comment@noreply.github.com Sent: Thursday, July 28, 2016 1:58 PM Subject: Re: [LibreEHR/LibreEHR] Review OpenEMR DevTip for good stuff (#2)

No, the link to the thread just isn't working for me. I tried a few times.

On 2016-07-28 01:52 PM, Tony McCormick wrote:

Just click on the pull request and read it ... if reading the SF thread is against your religion :-)

Tony McCormick, CTO www.mi-squared.com Support: 866-735-0897, Direct: 713-574-6709 My Calendar: http://bit.ly/XznvDo "Genuinely evolved interfaces are transparent, so transparent as to be invisible" - William Gibson

On Thu, Jul 28, 2016 at 10:48 AM, Art Eaton notifications@github.com wrote:

OK, for those of us not on that thread, what are these validation checks for?

On 2016-07-28 01:44 PM, Terry Hill wrote:

I got it and will commit it later

From: Tony McCormick notifications@github.com To: LibreEHR/LibreEHR LibreEHR@noreply.github.com Sent: Thursday, July 28, 2016 1:39 PM Subject: Re: [LibreEHR/LibreEHR] Review OpenEMR DevTip for good stuff (#2)

This looks likely to cherry-pick: https://mail.google.com/mail/u/0/#inbox/156305b953ab5e25 openemr/openemr#164— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub

https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235970329, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AAhzFy6Rda4SK_tR-dzMuk-BPnFIgXhbks5qaOqLgaJpZM4JN2s1

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235971518, or mute the thread

https://github.com/notifications/unsubscribe-auth/AARci0siQWeuUOB3MYXVGJur0W1HRogGks5qaOt5gaJpZM4JN2s1 .

Please be aware that e-mail communication can be intercepted in transmission or misdirected. Please consider communicating any sensitive information by telephone. The information contained in this message may be privileged and confidential. If you are NOT the intended recipient, please notify the sender immediately with a copy to hipaa-security@mrsb-ltd.com and destroy this message.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreEHR/LibreEHR/issues/2#issuecomment-235972748, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhzFwqDH76wyCw93KjBaH2AVopu_Vgpks5qaOx4gaJpZM4JN2s1.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

aethelwulffe commented 8 years ago

Do we have a commit on this yet?

teryhill commented 8 years ago

No not yet it is buggy with out the latest OEMR code

teryhill commented 8 years ago

oops hit the button by mistake

aethelwulffe commented 8 years ago

Is this a 1.0.1 issue?

aethelwulffe commented 8 years ago

Is this issue done?

teryhill commented 8 years ago

Yes. I will continue mining that repo for stuff as we go but this can be closed.

Sent from my iPhone

On Aug 31, 2016, at 12:10 AM, Art Eaton notifications@github.com wrote:

Is this issue done?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

aethelwulffe commented 8 years ago

This is, yes, a permanent ongoing, and not really an issue.