LibreHealthIO / lh-ehr

LibreHealth EHR - Free Open Source Electronic Health Records
Other
235 stars 260 forks source link

New Encounter Tab UI not clean when tab is narrow #741

Open tmccormi opened 6 years ago

tmccormi commented 6 years ago

See image. Closing the other tabs made it work. I am on a 22" monitor, Chrome Browser / Linux.

badnewenc-chromelinux

aethelwulffe commented 6 years ago

Also, open an encounter. Look at a fee sheet. Close fee sheet. New Encounter form still has a tab that says "Fee Sheet". Refresh. Now New Encounter form has a big old label with the date and stuff.

teryhill commented 6 years ago

@tmccormi I am not having that issue can you change your them to tan since that should be the only one we have.

image

aethelwulffe commented 6 years ago

Sorry, I always switch to purple/compact since that is the only we should have. -:) kidding, but tan looks like poo with the mips stuff I use. The buttons become unreadable in the measure selection, and the tabs on other things just take up waaaay too much white space. Also, the orange and pink...uh...

aethelwulffe commented 6 years ago

Honestly, one day we need to get around to addressing the white-space issue. The new UI elements are just too dang big. Everything requires scrolling.

tmccormi commented 6 years ago

why? the "light" the other one is tens times better that the Tan... We did we decide to have only Tan? The whole point of the light one is for the system to look modern, not like the bigO

Tony McCormick, CTO www.mi-squared.com Support: 866-735-0897, Direct: 713-574-6709 My Calendar: http://bit.ly/XznvDo -Verba volant, scripta manent

On Thu, Oct 26, 2017 at 12:05 PM, Terry Hill notifications@github.com wrote:

@tmccormi https://github.com/tmccormi I am not having that issue can you change your them to tan since that should be the only one we have.

[image: image] https://user-images.githubusercontent.com/4655366/32071966-064d58c4-ba5f-11e7-971b-5fe42a6d7ed3.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/LibreEHR/issues/741#issuecomment-339767400, or mute the thread https://github.com/notifications/unsubscribe-auth/AARciztdRHn32P0hR-ZUgiObdf_K_MjLks5swNfggaJpZM4QFXNV .

-- Please be aware that e-mail communication can be intercepted in transmission or misdirected. Please consider communicating any sensitive information by telephone. The information contained in this message may be privileged and confidential. If you are NOT the intended recipient, please notify the sender immediately with a copy to hipaa-security@mrsb-ltd.com and destroy this message.

tmccormi commented 6 years ago

PS, this is on a new install, so I'm using the default theme, which is Light not Tan. Should the style be changed in the installation?

We currently have

Tony McCormick, CTO www.mi-squared.com Support: 866-735-0897, Direct: 713-574-6709 My Calendar: http://bit.ly/XznvDo -Verba volant, scripta manent

On Thu, Oct 26, 2017 at 12:53 PM, Tony McCormick tony@mi-squared.com wrote:

why? the "light" the other one is tens times better that the Tan... We did we decide to have only Tan? The whole point of the light one is for the system to look modern, not like the bigO

Tony McCormick, CTO www.mi-squared.com Support: 866-735-0897, Direct: 713-574-6709 My Calendar: http://bit.ly/XznvDo -Verba volant, scripta manent

On Thu, Oct 26, 2017 at 12:05 PM, Terry Hill notifications@github.com wrote:

@tmccormi https://github.com/tmccormi I am not having that issue can you change your them to tan since that should be the only one we have.

[image: image] https://user-images.githubusercontent.com/4655366/32071966-064d58c4-ba5f-11e7-971b-5fe42a6d7ed3.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/LibreEHR/issues/741#issuecomment-339767400, or mute the thread https://github.com/notifications/unsubscribe-auth/AARciztdRHn32P0hR-ZUgiObdf_K_MjLks5swNfggaJpZM4QFXNV .

-- Please be aware that e-mail communication can be intercepted in transmission or misdirected. Please consider communicating any sensitive information by telephone. The information contained in this message may be privileged and confidential. If you are NOT the intended recipient, please notify the sender immediately with a copy to hipaa-security@mrsb-ltd.com and destroy this message.

teryhill commented 6 years ago

The discussion was that we would go with the Tan and @nileshprasad137 would do a color picker so we could choose colors and we were going to get away from maintaining all the themes and css's.

Just let me know how y'all want your project.

tmccormi commented 6 years ago

And changing to Tan does not fix it.

sameproblem

teryhill commented 6 years ago

Works fine on mine

tmccormi commented 6 years ago

Chrome on Linux is not the same as Chrome on Windows .... so this is an open but not urgent issue

aethelwulffe commented 6 years ago

EDITORIAL OPINION PIECE: Yes, and you need multiple themes, configurable by user, with user agent detection...and they must be maintained...or the theme needs to be really really smart. So, while I am given to understand that "Modern" === "Shit", then yes, the light theme is Modern. 😈 For me, it lacks contrast and makes things much harder for N00bs to the system to spot while trying to instruct them in use. Each theme will appeal to different people. This is not just a "I am Tony, I am a Man, and I am Scared of Color" issue, this is a problem with the way different people gauge contrast, see color, and a host of other eye-brain issues that we cannot just ignore. Some people see contrast where there is none (technically) due to position and other things, and others do not see contrast as well. Gradient colors help some dyslexia sufferers. Other folks simply perceive colors very differently, or to a different intensity (my clouds are pink, blue, and grey, not white). My main concern is density of data. We are currently...not very efficient. Efficient should be an option, and folks using their phone to play with the application should also have gigantic inputs that block the data results as much as they like.

tmccormi commented 6 years ago

Don't get me wrong, I prefer high contract dark background. My favorite was the Steel one. But this one looks good to people that want to buy the system from me. The others ALWAYS get the "that looks old, can you update it to something newer?" question.

I like the idea of a user configurable theme, but we don't have that yet... In any case this issue is not a problem with the theme at all, it's an incompatibility issue with Chrome on Linux I think.

nileshprasad137 commented 6 years ago

Looks like there are multiple issues with UI .I'll try to find some time to work upon them.

On 27 Oct 2017 01:53, "Tony McCormick" notifications@github.com wrote:

Don't get me wrong, I prefer high contract dark background. My favorite was the Steel one. But this one looks good to people that want to buy the system from me. There others ALWAYS get the "that's looks old, can you update it to something newer?" question.

I like the idea of a user configurable theme, but we don't have that yet... In any case this issue is not a problem with the theme at all, it's an incompatibility issue with Chrome on Linux I think.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/LibreEHR/issues/741#issuecomment-339789840, or mute the thread https://github.com/notifications/unsubscribe-auth/APlGBiskLMOHLGU-BUVLITxHy6omno0Hks5swOpJgaJpZM4QFXNV .

nileshprasad137 commented 6 years ago

I think this issue wasn't present some time back. I'd look at it.

On 27 Oct 2017 05:52, "Nilesh Prasad" prasadnilesh96@gmail.com wrote:

Looks like there are multiple issues with UI .I'll try to find some time to work upon them.

On 27 Oct 2017 01:53, "Tony McCormick" notifications@github.com wrote:

Don't get me wrong, I prefer high contract dark background. My favorite was the Steel one. But this one looks good to people that want to buy the system from me. There others ALWAYS get the "that's looks old, can you update it to something newer?" question.

I like the idea of a user configurable theme, but we don't have that yet... In any case this issue is not a problem with the theme at all, it's an incompatibility issue with Chrome on Linux I think.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/LibreEHR/issues/741#issuecomment-339789840, or mute the thread https://github.com/notifications/unsubscribe-auth/APlGBiskLMOHLGU-BUVLITxHy6omno0Hks5swOpJgaJpZM4QFXNV .