search

LibreHealthIO / lh-ehr

LibreHealth EHR - Free Open Source Electronic Health Records
Other
238 stars 262 forks source link

Pressing Lock and then Refresh on a UI Element Creates Two Instances #882

Closed Kachachan closed 6 years ago

Kachachan commented 6 years ago

Steps to Reproduce

  1. Click on the 'Lock' on one of the UI elements. This hides the element. libreehr9

  2. Whilst the element is hidden, click on the 'refresh' button. Observe two instances of the same element being created. libreehr10

Seems like if you open the hidden one, the opened one gets replaced, though. So in the end only one instance of the element will be displayed anyway. Minor UI bug.

Reproduction Rate: 5/5

System Specs LibreHealth EHR v2.0.0, Chrome Version 63.0.3239.84 (Official Build) (64-bit), Windows 10 Version 10.0.14393 Build 14393

apooravc commented 6 years ago

In terms of element UI, what is the use of having refresh icon when an element is locked or hidden? Isn't that an extra thing to have in the hidden state? Besides having unlock and close. @teryhill @aethelwulffe

teryhill commented 6 years ago

@apooravc goodpoint. That would fix this error.

aethelwulffe commented 6 years ago

facepalm SMACK. Yeah, the refresh icon in that context is a little stupid.

aethelwulffe commented 6 years ago

@Kachachan You want to handle hiding that icon when in lock mode? Who do we assign this to?

apooravc commented 6 years ago

I can do it if @Kachachan has no issues.