search

LibrePCB-Libraries / LibrePCB_Connectors.lplib

Official LibrePCB Connectors Library
Creative Commons Zero v1.0 Universal
1 stars 4 forks source link

Add 2-Row Pin Headers / Sockets #6

Closed dbrgn closed 5 years ago

dbrgn commented 5 years ago

Phew, that took quite some time to refactor & implement :slightly_smiling_face:

Header and socket symbols:

img img

Header and socket packages:

img img

I also included a few refactorings & fixes in the existing elements (e.g. non-overlapping silkscreen / pads in packages).

Note 1: I did not include generic 2-row connector symbols. I don't think it's needed, the single-row connectors can be used as well. Similarly, I did not create 2-row soldered wire connectors. Soldering wires to a 2x20 pad connector is very unlikely.

Note 2: The single-row symbols could be added as symbol variant to the 2-row components. I.e. instead of a 2x4 symbol, a 1x8 symbol could be used too. Do you agree, @ubruhin? If yes, I could do that in a separate PR.

ubruhin commented 5 years ago

Thanks, the new connectors look good! :+1:

But as always, some nagging :grin: In 101d94ce46b7ead8fd9b6b27533881cb7397c792 you sorted pad-signal mappings, but in db940fa225e93d098a4d0677a6c79388d21acc42 you reverted them, that's probably not intended?

Note 1: I did not include generic 2-row connector symbols. I don't think it's needed, the single-row connectors can be used as well. Similarly, I did not create 2-row soldered wire connectors. Soldering wires to a 2x20 pad connector is very unlikely.

:+1:

Note 2: The single-row symbols could be added as symbol variant to the 2-row components. I.e. instead of a 2x4 symbol, a 1x8 symbol could be used too. Do you agree, @ubruhin? If yes, I could do that in a separate PR.

Hmm actually I don't really see the need for this...

dbrgn commented 5 years ago

But as always, some nagging grin In 101d94c you sorted pad-signal mappings, but in db940fa you reverted them, that's probably not intended?

Ah, actually it seems that the commit which supposedly sorts those mapings didn't actually sort them properly :smile:

dbrgn commented 5 years ago

@ubruhin I believe it's fixed now!