search

LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

Only trigger CI builds on master branch and pull requests #118

Open rnestler opened 1 year ago

rnestler commented 1 year ago

If we trigger on every branch we will have redundant CI runs for branches with pull requests.

ubruhin commented 1 year ago

Hm actually I prefer getting CI feedback right on the first push of a new branch, without requiring to open a PR (yet) :see_no_evil: IMHO the redundant CI runs are not a real problem as the runs are pretty fast, i.e. not wasting much time and resources...

rnestler commented 9 months ago

Hm actually I prefer getting CI feedback right on the first push of a new branch, without requiring to open a PR (yet) 🙈 IMHO the redundant CI runs are not a real problem as the runs are pretty fast, i.e. not wasting much time and resources...

I was just annoyed by the 8 checks showing up. If I want CI I open a PR, if it's not ready yet I mark it as draft.

rnestler commented 4 months ago

I mean CI takes less then a minute in this project. If you want feedback before opening a PR you can run the tests locally.