LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

JST SH: Add MPNs with 'suction cap' attribute and 'JST ' dev prefix #131

Closed nbes4 closed 5 months ago

nbes4 commented 5 months ago

This PR adds:

Discussions about the changes: https://github.com/LibrePCB/librepcb-parts-generator/pull/127#issuecomment-2079003507 ('suction cap' MPNs) https://github.com/LibrePCB-Libraries/JST.lplib/pull/5#issuecomment-2114075846 (JST prefix)

nbes4 commented 5 months ago

Thanks for the swift review, I implemented your feedback!

ubruhin commented 5 months ago

Alright, I'd say this looks good now! :muscle:

Could you open the corresponding PR on the library repository?

nbes4 commented 5 months ago

Done, there you go https://github.com/LibrePCB-Libraries/JST.lplib/pull/6 🚀

ubruhin commented 5 months ago

Library PR merged :muscle: Thank you!