LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

Always use Unix-style line endings in generator output #132

Closed nbes4 closed 3 months ago

nbes4 commented 3 months ago

This PR adds:

I tried the librepcb-cli open-library --all --strict --check --minify-step . command before the changes in this PR and it gave me the "Non-canonical file". After applying the changes in this PR it seemed to work just fine! :-)

Edit: I verified the Tests on my Windows machine. They failed before applying the changes, but passed after applying the changes from this PR.

nbes4 commented 3 months ago

@dbrgn Thanks for the review, I implemented your feedback!

Did you test whether the test actually fails when running on Windows without the fix?

Yes, I forgot to mention that but I did run the tests on my Windows machine before applying the changes in this PR and they failed, but passed once I applied the changes 👍 I updated the initial PR description to make it more clear upfront 😄

nbes4 commented 3 months ago

Thanks for merging 🎉

@rnestler more coverage never hurts IMO 👍