Closed dbrgn closed 5 years ago
Is there a PR already for the generated parts?
Arghh, somehow the suggested changes look wrong:
There is no line with only pkg-ssop
, no idea whether applying the suggestion will do the correct change :sob:
No problem, I'll apply them manually.
@ubruhin I updated https://github.com/LibrePCB-Libraries/LibrePCB_Base.lplib/pull/35 with your changes.
Oh, and regarding this question:
Beside this: Are pad positions rounded to 2 decimal places somewhere? I ask because in the packages with 0.65mm pad spacing and even number of pads per side (e.g. SSOP28), pads have an Y offset of +/-0.33mm instead of +/-0.325mm. Thus the two pads in the middle have a spacing of 0.66mm instead of 0.65mm.
Hm, you're right. In general (format_float(...)
) we round to 3 decimal places, but in the get_y
function in generate_so.py
we round to 2 decimal places. I'll adjust that.
Changed in ef6a98a576c05d311353c00c1be3e6d9bfe5c78b. I pushed fixup commits to https://github.com/LibrePCB-Libraries/LibrePCB_Base.lplib/pull/35. The other affected parts will have to be updated in a separate PR.
Library PR is merged!
Generate SSOP parts based on JEDEC MO-150 and MO-152.
Based on #28, merge that first!
Fixes #24.