search

LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

Reorganize repository structure #65

Open rnestler opened 4 years ago

rnestler commented 4 years ago

Currently the repository contains almost everything in top level. Would it make sense to add directories for the UUID caches for example?

dbrgn commented 4 years ago

Yeah, probably wouldn't hurt!

ouabache commented 4 years ago

Ok, Here's my proposal.

Keep all python at the top level.

Each Library on the librePCB server gets it's own directory for uuid_caches and run scripts

We need to get to the point where we can automatically regenerate all of our libraries from scripts using the lower level python code.

ouabache commented 4 years ago

I tried setting up a directory for the Base library and ran into some issues.

The generate_chips.py is old. It generates version 0.3 while 0.3.2 is checked in

the chip and so scripts have round off errors. The checked in versions have Y positions to 2 digits but I am generating 3. I am running python3.7

dbrgn commented 4 years ago

The generate_chips.py is old. It generates version 0.3 while 0.3.2 is checked in

Ah, #64 wasn't merged yet even though the library PR was already merged.

You can pull master, should be fixed.

ouabache commented 4 years ago

Thank you.

I am now going to fix the problem with the names for the DIP packages

On Sat, Jan 18, 2020, 6:12 AM Danilo Bargen notifications@github.com wrote:

The generate_chips.py is old. It generates version 0.3 while 0.3.2 is checked in

Ah, #64 https://github.com/LibrePCB/librepcb-parts-generator/pull/64 wasn't merged yet even though the library PR was already merged.

You can pull master, should be fixed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibrePCB/librepcb-parts-generator/issues/65?email_source=notifications&email_token=AAKX3XCUREU3ZA4JUTB35CLQ6ME4LA5CNFSM4JTXH6I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJJZAQY#issuecomment-575901763, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKX3XCPVSH6QDVQHBWJCJDQ6ME4LANCNFSM4JTXH6IQ .

ouabache commented 4 years ago

Still not right.

There are 11 devices with version 0.3 when the script calls out 0.3.2

Everything else synced up

ouabache commented 4 years ago

The generate_so.py script doesn't match the checked in code. In some cases there are different create_dates and the number of places returned by the get_y function varies between 2 or 3

dbrgn commented 4 years ago

There are 11 devices with version 0.3 when the script calls out 0.3.2

This is now fixed in master.

The generate_so.py script doesn't match the checked in code. In some cases there are different create_dates and the number of places returned by the get_y function varies between 2 or 3

I added commit 5db97430e116ea36aac331646b287daab2ee3fe1 when generating the SSOP packages, but then did not re-generate the SOIC packages. I fixed that in PR https://github.com/LibrePCB-Libraries/LibrePCB_Base.lplib/pull/57.

I also collapsed the last few comments in this thread, since they're offtopic :slightly_smiling_face: