search

LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

DFN generator improvements #69

Closed dbrgn closed 4 years ago

dbrgn commented 4 years ago

The first two changes only affect third party (custom) packages, while the third change (show package outline on documentation layer) affects the base lib as well.

The change even makes an error in the generator visible: The silkscreen should be around the package body, but it's on the package body :) Maybe I'll fix that as well (tomorrow).

img

dbrgn commented 4 years ago

I have trouble understanding the code that generates the silkscreen line, so let's keep this PR as-is for now. It can be reviewed (should be quite simple).

I'll also create a PR against the base lib.

dbrgn commented 4 years ago

Since #70 was approved (which builds on this PR), I'd consider that an implicit approval :wink: