search

LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

added script for generating Pin Grid Array packages #72

Open ouabache opened 4 years ago

ouabache commented 4 years ago

added uuids for 3 pga packages

dbrgn commented 4 years ago

@ouabache it seems that you added both PGA and BGA generators in this pull request. can you split them up?

To revert the second commit, you can do:

git revert 1c7226b
git push
ouabache commented 4 years ago

I actually put two different scripts together. You should add both the bga and pga ones.

On Sat, Jan 18, 2020 at 1:44 PM Danilo Bargen notifications@github.com wrote:

@ouabache https://github.com/ouabache it seems that you added both PGA and BGA generators in this pull request. can you split them up?

To revert the second commit, you can do:

git revert 1c7226b git push

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibrePCB/librepcb-parts-generator/pull/72?email_source=notifications&email_token=AAKX3XGV7P4EU357IDHWOATQ6NZ5PA5CNFSM4KINNIVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKCTWI#issuecomment-575941081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKX3XF5NCBE4PL6GCCMS23Q6NZ5PANCNFSM4KINNIVA .

dbrgn commented 4 years ago

I'm confused... Didn't you add the BGA script in #67?

ouabache commented 4 years ago

I did create a b g a branch for the b g a script but have since added some extra scripts for generating components from c v s files and kicad files. Those will need some more work before they can be accepted.

The b g a script is near ready and I copied it into the fpga branch so we can do both at the same time.

They are essentially the same script,all I need to do is lint them

On Sun, Jan 19, 2020, 4:40 AM Danilo Bargen notifications@github.com wrote:

I'm confused... Didn't you add the BGA script in #67 https://github.com/LibrePCB/librepcb-parts-generator/pull/67?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibrePCB/librepcb-parts-generator/pull/72?email_source=notifications&email_token=AAKX3XDIGVG5GN5LTL2M7K3Q6RC2HA5CNFSM4KINNIVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKRFKA#issuecomment-576000680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKX3XCENFK422OT4NQTYZ3Q6RC2HANCNFSM4KINNIVA .