LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

Rework DIP package generator #75

Closed dbrgn closed 1 year ago

dbrgn commented 4 years ago

This is a total rework of DIP package generator. Another one of those PRs where I thought "let me quickly do those changes", but then I spent a total of 10-15 hours on it :sweat_smile: (Mostly research)

Version has been bumped to v0.2.0.

This PR also includes the changes by @ouabache in #73. Fixes #32.

I'll create a PR against the base library for easier discussion.

ubruhin commented 2 years ago

Generally very nice rework & documentation! :rocket:

I didn't review everything in detail yet, but my comments so far:

If you agree on these changes but don't have the time to implement it, maybe we could do it the same way as for the LED generator that I implement the changes in a separate PR?

ubruhin commented 1 year ago

@dbrgn may I rebase this branch and apply the suggestions from https://github.com/LibrePCB/librepcb-parts-generator/pull/75#issuecomment-1233027784? Since this is almost ready it would be nice to finally get it merged :)

dbrgn commented 1 year ago

Sorry, I forgot about this PR... Sure, your suggestions sound reasonable, go ahead 🙂

ubruhin commented 1 year ago

Alright, I rebased and added two commits with these changes:

Result:

image

image

dbrgn commented 1 year ago

🎉