Closed dbrgn closed 1 year ago
Generally very nice rework & documentation! :rocket:
I didn't review everything in detail yet, but my comments so far:
DIP787W55P254L965H533Q8
) is very confusing because the "787" is not a well-known DIP lead span. See for example here that they call it DIP762...
for a nominal lead span of 7.62mm. Thus I'd highly recommend to adjust our package name as well to contain the nominal lead span, not the outer lead span.If you agree on these changes but don't have the time to implement it, maybe we could do it the same way as for the LED generator that I implement the changes in a separate PR?
@dbrgn may I rebase this branch and apply the suggestions from https://github.com/LibrePCB/librepcb-parts-generator/pull/75#issuecomment-1233027784? Since this is almost ready it would be nice to finally get it merged :)
Sorry, I forgot about this PR... Sure, your suggestions sound reasonable, go ahead 🙂
Alright, I rebased and added two commits with these changes:
Result:
🎉
This is a total rework of DIP package generator. Another one of those PRs where I thought "let me quickly do those changes", but then I spent a total of 10-15 hours on it :sweat_smile: (Mostly research)
Version has been bumped to v0.2.0.
This PR also includes the changes by @ouabache in #73. Fixes #32.
I'll create a PR against the base library for easier discussion.