LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

Add STM32 generator #80

Closed dbrgn closed 3 years ago

dbrgn commented 4 years ago

Based on data from https://github.com/LibrePCB/stm32-pinout, based on initial work by @ouabache.

dbrgn commented 4 years ago

Current blocker: LibrePCB doesn't like parentheses in signal names.

[EXCEPTION] Invalid identifier: 'PA13 (JTMS/SWDIO)' (../../../../libs/librepcb/common/circuitidentifier.h:54)
[EXCEPTION] File parse error: Invalid identifier: 'PA13 (JTMS/SWDIO)'
ouabache commented 4 years ago

I parsed out everything after the space. That seemed to work

On Wed, Mar 4, 2020, 12:58 PM Danilo Bargen notifications@github.com wrote:

Current blocker: LibrePCB doesn't like parentheses in signal names.

[EXCEPTION] Invalid identifier: 'PA13 (JTMS/SWDIO)' (../../../../libs/librepcb/common/circuitidentifier.h:54) [EXCEPTION] File parse error: Invalid identifier: 'PA13 (JTMS/SWDIO)'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibrePCB/librepcb-parts-generator/pull/80?email_source=notifications&email_token=AAKX3XCTTRDWNYY6XR2ANX3RF26JBA5CNFSM4KU45CGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN2HXYI#issuecomment-594836449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKX3XDPXSQNYTNC4THJ6YTRF26JBANCNFSM4KU45CGA .

dbrgn commented 4 years ago

Also TODO: Group components by GPIO version, not purely by pinout.

This results in more variants, but is more future-proof if we add support for AFs.

dbrgn commented 4 years ago

I parsed out everything after the space. That seemed to work

Stripping the text after pinout resulted in duplicates. I then noticed that some pins have remapped alternatives, these need to be ignored.

PR should be ready now!

dbrgn commented 3 years ago

@ubruhin Thanks for your two assertion commits, I added them to this branch!