search

LibrePCB / librepcb-parts-generator

A collection of scripts to generate parts for the LibrePCB default library
MIT License
7 stars 14 forks source link

dfn: Add Microchip MC style config #85

Closed dbrgn closed 2 years ago

dbrgn commented 3 years ago

See https://github.com/LibrePCB-Libraries/LibrePCB_Base.lplib/pull/85 and https://github.com/LibrePCB-Libraries/Microchip.lplib/issues/17.

dbrgn commented 2 years ago

Note, in https://github.com/LibrePCB-Libraries/LibrePCB_Base.lplib/pull/85 I wrote:

The other variant can be kept.

I think if we want to keep the other variant (without marking it as deprecated) we should keep the config in here as well.

Alternatively, we should mark the other variant as deprecated.

@ubruhin do you agree?

ubruhin commented 2 years ago

Yeah I also think either the old one should be marked as deprecated, or should be kept in the generator to ensure it receives any future updates from the DFN generator.

If the old one is simply a mistake and is not useful at all I think I'd deprecate it, but I'd also be fine with the other way.

dbrgn commented 2 years ago

I think it's a mistake, so let's deprecate it.