search

LibrePDF / OpenPDF

OpenPDF is a free Java library for creating and editing PDF files, with a LGPL and MPL open source license. OpenPDF is based on a fork of iText. We welcome contributions from other developers. Please feel free to submit pull-requests and bugreports to this GitHub repository.
Other
3.63k stars 598 forks source link

Limited functionality under Google App Engine #23

Closed Radagan closed 7 years ago

Radagan commented 7 years ago

Hi, is there a way to get rid of the dependency on java.awt.Color? It's not white listed on GAE, so setting cell colors, etc. will not work. This library is amazing otherwise. I've tried PDFBox and it is years from where this library is.

ghost commented 7 years ago

Hi! Yes, this is possible. Can you please submit a pull-request for this?

java.awt.Color is found 153 places in the source code, and "Color" many thousand. So this could be large change.

Radagan commented 7 years ago

Hi Andreas,

I must be doing something wrong... When I press "New Pull Request" it sends me here:

screen shot 2017-03-09 at 9 45 55 am

Happy to do what I can if you'll point me in the right direction.

ghost commented 7 years ago

Hi!

Here is a suggestion:

  1. Propose a suggestion about how you suggest you change OpenPDF to work on Google App Engine in this issue. It would be very nice to have OpenPDF working on GAE! However, I don't think we should break the API for existing users of OpenPDF. How can we solve this? Perhaps create a different branch of OpenPDF with java.awt.Color replaced with our own Color class?

  2. Then create a fork of github.com/LibrePDF/OpenPDF to github.com/Radagan/OpenPDF by clicking the "Fork" button on the github.com/LibrePDF/OpenPDF repo.

  3. Then click "pull request" on github.com/Radagan/OpenPDF to create a request to get your changes pulled into github.com/LibrePDF/OpenPDF.

Andreas

Radagan commented 7 years ago

Thanks, Andreas.

I confess this is the first time I’ve ever contributed to an open source project, much less on GitHub. This should be fun!

I’ll do as you suggest. I suffered with the state of PDFBox up close for a few days, and then found your fork of the old LGPL version of iText. Our company would happily buy iText if they had anything close to a normal software license agreement, but it’s more complex than the current US Tax code. Crazy.

OpenPDF must not die.

I’ve been coding Java for a couple decades and I’ve got more than a little vested interest in it working on GAE. Thank you for being open to my making a contribution.

Fortunately, it’s working under GAE now so long as you don’t mess with colors. But colors would be nice to have, and there may be other GAE particulars I can help with.

Kind regards,

Rolf

On Mar 9, 2017, at 4:23 PM, Andreas Røsdal notifications@github.com wrote:

Hi!

Here is a suggestion:

Propose a suggestion about how you suggest you change OpenPDF to work on Google App Engine in this issue. It would be very nice to have OpenPDF working on GAE! However, I don't think we should break the API for existing users of OpenPDF. How can we solve this? Perhaps create a different branch of OpenPDF with java.awt.Color replaced with our own Color class?

Then create a fork of /LibrePDF/OpenPDF on github.com/Radagan

Then click "pull request" on github.com/Radagan

Andreas

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibrePDF/OpenPDF/issues/23#issuecomment-285266247, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnkIjCNi57cj6jjM8he80r-2LrqETKhks5rj5r9gaJpZM4MWYVb.

ghost commented 7 years ago

This sounds like a good plan. Your contributions will be very welcome!

jeeban13 commented 7 years ago

How to use openPDF object in vbscript and C# because customer installed openPDF software to view and edit pdf files

ghost commented 7 years ago

@Radagan Any news on this issue?

Radagan commented 7 years ago

@Andreas. With Google releasing the flexible environment, this is less of an issue. The library works under standard so long as you don’t use the color methods, and under flexible there are not restrictions. So, I would close the feature request as no longer needed. Even with a standard app engine project, one should be able to break the pdf portion off into a micro-service running under flexible and use all of the features of LibrePDF as written.

On May 16, 2017, at 10:44 PM, Andreas Røsdal notifications@github.com wrote:

@Radagan https://github.com/radagan Any news on this issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibrePDF/OpenPDF/issues/23#issuecomment-301770489, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnkIqGoa4Wo7EzFoIVmtXCsLGliR9inks5r6Zo0gaJpZM4MWYVb.