LibrePhotos / librephotos-docker

You can find here the Dockerfiles for the automated build process of LibrePhotos.
MIT License
157 stars 101 forks source link

do not install CUDA dependencies #82

Closed sickelap closed 1 year ago

sickelap commented 1 year ago

Because we are using CPU for AI work, we don't need to install CUDA dependencies which takes considerable amount of disk space with no reason. This change reduce image size (for x86_64) by 2.6 GB.

Tested by scanning fresh installation with 4.5k photos. Face detection and scene detection worked fine.

Before applying changes:

reallibrephotos/librephotos                latest     c50f15649b37   29 hours ago        7.3GB
reallibrephotos/librephotos-dependencies   dev        6903e652f43a   4 weeks ago         6.57GB
reallibrephotos/librephotos-base           dev        75c120a59221   4 weeks ago         5.6GB

After applying changes:

reallibrephotos/librephotos                latest     74005f3a6941   15 minutes ago      4.68GB
reallibrephotos/librephotos-dependencies   dev        552a79c4b474   18 minutes ago      3.95GB
reallibrephotos/librephotos-base           dev        574018ce1df0   25 minutes ago      2.97GB
derneuere commented 1 year ago

Looks good to me! Do you have an idea on how we handle gpu processing in the future? Will we add just another image with the cuda dependencies?

sickelap commented 1 year ago

Yes, I think if we would want to have an image which has GPU support it would be in a separate image with a tag specifying the features like TensorFlow, Cuda and others

Nerodacles commented 1 year ago

Yes, I think if we would want to have an image which has GPU support it would be in a separate image with a tag specifying the features like TensorFlow, Cuda and others

Yea, it think its better if we create a another image!