Open alfwro13 opened 11 months ago
The behavior you are describing is the expected behavior LibrePhotos should have in a normal scan. All possible images are added to the task list, but every image which does not have a newer modified timestamp then the last scan will get skipped. This is something you can test yourself on the demo server. The first scan takes around 7 minutes and the second one takes a second.
If you have deleted the last successful scan from the job list, this will trigger a complete rescan. If you moved all images, within the folder, this will also trigger a rescan. If it was modified by an external program and has a newer modified timestamp, this will also result in a rescan.
If you can give me steps on how I can reproduce this, I can do a bug fix :)
If you have deleted the last successful scan from the job list, this will trigger a complete rescan.
This is surprising and confusing behavior. In the UI, the job list is called "Worker Logs". I wouldn't expect that clearing old, finished entries from a "log" would significantly alter the behavior of the program. As I wait for yet another face detection in 120k images, I just learned of that behavior from this issue.
Could that either get more clear documentation directly in the Worker Logs UI, or a warning to that effect when removing the last successful scan? Alternatively, could the boolean of whether a full scan has already occurred be tracked in the database, independent of the Worker Logs?
I need to know, when the successful last scan happened. Only images with newer modified timestamps since the last successful scan are processed, while others are skipped. Deleting the last successful scan triggers a full rescan, as the program no longer has a reference point. I don't think saving the same information a second time would help resolve this, as this creates more issues down the line.
I didn't find it too confusing, but maybe a renaming it to something more intuitive, like "Scan History" or "Scan Records," might clarify their importance and prevent accidental deletions.
I could also implement a soft delete for scans, so the data remains in the system but is hidden from the UI.
Could you clarify why you removed the entries?
Sometimes when there are a lot of completed and/or failed tasks, such as the tasks initiated from the manage.py scan command in a nightly cron job, especially with several users, the "log" looks very messy. If there are hung tasks in the mix, it keeps the status red, indicating no more heavyweight processes can be started. It can be difficult to hunt down the offending hung task. I've gotten in the habit of simply rapidly clicking to delete all of them. I feel like in previous versions, that had not resulted in the full AI-based face detection happening again, but in the latest version, it does.
Really anything that would just make it more obvious that deleting that completed scan will cause a full rescan, would be helpful I believe.
Describe the enhancement you'd like At the moment from what I can see there is no quick way of re-scanning newly added pictures (unless I am missing something). It took me 3 days to perform (around 100K photos) initial scan and wrongly I have assume that subsequent scans will be quicker but that doesn't appear to be the case. Each scan takes equally long.
Describe why this will benefit the LibrePhotos There should be a way of performing quick scan just to add new photos otherwise using librephotos for large collections is will be unpractical.
Additional context Add any other context or screenshots about the enhancement request here.