Adapt tests - Githubissues

the01 commented 1 month ago

Changed patched logger to use the one from file (I find it easier to work with a new logger per file logger = logging.getLogger(__name__) and to include the logger name in the log message; the change supports both variants)
assertEquals -> assertEqual (this has been deprecated since 3.1 and has now been removed in Python 3.12)
SharePhotosTest: shared -> val_shared (not sure, but since the FE also uses val_shared, I assume this is correct)
test_user: added llm_settings

The following tests did not work with python manage.py test and I couldn't figure out how to adapt them:

api/tests/test_photo_summary.py: the whole PhotoSummaryViewTest (reverse("photo-summary",..) fails as there is no endpoint)
api/tests/test_reading_exif.py: ReadFacesFromPhotosTest.test_reading_from_photo (in get_face_encodings() it tries to connect to http://localhost:8005/face-encodings, but the tests do not start this endpoint - maybe this should be mocked)

sonarcloud[bot] commented 1 month ago

Quality Gate passed

derneuere commented 1 month ago

Thanks for diving into the tests! 😊 As you can see, they're still quite basic and don't yet run on pull request or merge.

Typically, I run the tests within the container. You can find where the services are called here and they can be started with a Django command.

Not entirely sure why test_photo_summary.py is failing, but I'll look into it! 😅