search

LibrePhotos / librephotos

A self-hosted open source photo management service. This is the repository of the backend.
MIT License
6.77k stars 297 forks source link

OpenID support #401

Open tomlawesome opened 2 years ago

tomlawesome commented 2 years ago

Describe the enhancement you'd like Add support for OpenID connect

Describe why this will benefit the LibrePhotos Improved connectivity with well-established authentication systems encourages a wider user base.

Additional context One of the major barriers to self/community hosting is encouraging users to use the services you host. One of the biggest barriers to this is multiple logins for different services. Implementing SSO removes this barrier. For the individual user SSO removes having yet another account to manage.

Apologies if this has been requested before. I searched but found nothing.

tieb62 commented 1 year ago

Would be a huge improvement Will it be implemented ? If yes any ETA ?

Scot-Survivor commented 1 year ago

I feel this could be easily implemented by switching to using Django-All-Auth for authentication. And allowing admin users to access the generic admin page (so they can add their social app providers easily)

derneuere commented 1 year ago

We mostly rely on JWT authentication and not session based authentication. If you implement this, make sure that django-rest-auth generates proper JWT tokens after logging in with Django-All-Auth.

Scot-Survivor commented 1 year ago

Yeah that makes sense.