Replace regex-based email validation

[AudreyBeard]

Describe the enhancement you'd like Replace regex-based email validation with something more robust & easier to read

Describe why this will benefit the LibrePhotos It appears the general consensus on email validation is that regex is a suboptimal solution. I'm no expert here, but some compelling arguments I've seen are:

• it's difficult to read and maintain
• if it's not overly difficult to read, it's likely violating RFC 5322

The current solution for email validation has proven problematic at least twice, including #689, #637; perhaps more.

Additional context This SO post shows exactly how complicated a "proper" regex-based email validator would be, and it's essentially impossible to read:

(?:[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*|"(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21\x23-\x5b\x5d-\x7f]|\\[\x01-\x09\x0b\x0c\x0e-\x7f])*")@(?:(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?|\[(?:(?:(2(5[0-5]|[0-4][0-9])|1[0-9][0-9]|[1-9]?[0-9]))\.){3}(?:(2(5[0-5]|[0-4][0-9])|1[0-9][0-9]|[1-9]?[0-9])|[a-z0-9-]*[a-z0-9]:(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21-\x5a\x53-\x7f]|\\[\x01-\x09\x0b\x0c\x0e-\x7f])+)\])

[sickelap]

I do agree that regexp for the correct email is complex. But I also want to point out that all variations of the valid email are rarely used. That's why the current implementation is capturing the most commonly used email formats.

Whatever the current solution is, it is not set in stone. If you have an email address that the current pattern does not match, you are free to update the pattern yourself. If you think there is a better solution to verify email address correctness, feel free to share.

[AudreyBeard]

You've got a fair point; it sounds like a low-priority (and perhaps low-effort) task. In the meantime I suppose we can continue updating the regex when issues arise.

I'd love to contribute here, but I've got no experience with TypeScript (or any front-end work really), so I'm probably not the best person to work on this issue specifically.

Maybe a good first issue for someone with more experience and interest in TS or front-end development?