search

LibrePlan / libreplan

LibrePlan - Open Web Planning
https://www.libreplan.dev
GNU Affero General Public License v3.0
289 stars 170 forks source link

NullPointerException handling progress #1406

Closed kwoot closed 6 years ago

kwoot commented 12 years ago

(Original Bugzilla Bug ID: 1262)

Date: 2011-11-16 08:58:21 From: Javier Morán \<jmoran@igalia.com> To: Manuel Rego Casasnovas \<rego@igalia.com> Version: libreplan-1.2 (1.2.x) Last updated: 2011-11-16 12:46:40

(Note: this issue was migrated automatically with bugzilla2github.py tool )

kwoot commented 6 years ago

Bugzilla Comment ID: 3367 Date: 2011-11-16 08:58:21 From: Javier Morán \<jmoran@igalia.com>

Do the following steps:

At this point the following exception happens:

java.lang.NullPointerException at org.libreplan.business.advance.entities.DirectAdvanceAssignment.removeAdvanceMeasurement(DirectAdvanceAssignment.java:168) at org.libreplan.web.orders.ManageOrderElementAdvancesModel$CancelOperation.addRemovedMeasurements(ManageOrderElementAdvancesModel.java:845) at org.libreplan.web.orders.ManageOrderElementAdvancesModel$CancelOperation.restoreOriginalState(ManageOrderElementAdvancesModel.java:819) at org.libreplan.web.orders.ManageOrderElementAdvancesModel.cancel(ManageOrderElementAdvancesModel.java:246) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:198) at $Proxy143.cancel(Unknown Source) at org.libreplan.web.orders.ManageOrderElementAdvancesController.cancel(ManageOrderElementAdvancesController.java:122) at org.libreplan.web.planner.advances.AdvanceAssignmentPlanningController.cancel(AdvanceAssignmentPlanningController.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at bsh.Reflect.invokeMethod(Unknown Source) at bsh.Reflect.invokeObjectMethod(Unknown Source) at bsh.Name.invokeMethod(Unknown Source) at bsh.BSHMethodInvocation.eval(Unknown Source) at bsh.BSHPrimaryExpression.eval(Unknown Source) at bsh.BSHPrimaryExpression.eval(Unknown Source) at bsh.Interpreter.eval(Unknown Source) at bsh.Interpreter.eval(Unknown Source) at org.zkoss.zk.scripting.bsh.BSHInterpreter.exec(BSHInterpreter.java:134) at org.zkoss.zk.scripting.util.GenericInterpreter.interpret(GenericInterpreter.java:341) at org.zkoss.zk.ui.impl.PageImpl.interpret(PageImpl.java:876) at org.zkoss.zk.ui.impl.EventProcessor.process0(EventProcessor.java:180) at org.zkoss.zk.ui.impl.EventProcessor.process(EventProcessor.java:138) at org.zkoss.zk.ui.impl.EventProcessingThreadImpl.process0(EventProcessingThreadImpl.java:517) at org.zkoss.zk.ui.impl.EventProcessingThreadImpl.run(EventProcessingThreadImpl.java:444)

kwoot commented 6 years ago

Bugzilla Comment ID: 3375 Date: 2011-11-16 12:46:40 From: Manuel Rego Casasnovas \<rego@igalia.com>

commit bbb56115461228765325f0be000d6965b7b33142 Author: Manuel Rego Casasnovas rego@igalia.com Date: Wed Nov 16 13:34:34 2011 +0100

[Bug #1262] Remove option to cancel progress assignments in Gantt view

It makes this window coherent with the one in WBS.

Moreover, there were more problems than the one described in the bug
itself. For example, if you remove a progress type and click cancel, the
progress is removed when you come back to the pop-up.

The problem is that we're not working against a copy so in cancel button
we need to revert all the changes done, which is quite complicated. So,
at this moment the decision is remove this option.

FEA: ItEr75S04BugFixing