search

LibrePlan / libreplan

LibrePlan - Open Web Planning
https://www.libreplan.dev
GNU Affero General Public License v3.0
287 stars 169 forks source link

Used version of jQuery incompatible to modern Browsers #1910

Open grypho opened 5 years ago

grypho commented 5 years ago

Libreplan uses a version of jQuery (1.10.2) which was released 2013. There are several issues with modern browsers that prevent proper event-handling and there will be more deprecations in the future (i.e. event.returnValue) which will break the logic in some Browsers.

For testing purposes I patched zk-8.6.0.1.jar with the most recent jQuery-3.4.1 and jQuery-Migrate-1.4.1

After setting jq = jQuery; at the end of the file, the modern version works with only a few deprecation warnings.

Results:

  1. My assumption that #1909 is related to the old jQuery library seems to be wrong.
  2. The surface seems to be much faster (subjective) than with jQuery 1.10
kwoot commented 5 years ago

Getting rid of technical debt like old libs is always a good thing. When it works and looks to be an improvement, lets roll out. :-)