When from the list of advances you try to delete an advance type exception happens

[kwoot]

(Original Bugzilla Bug ID: 359)

Date: 2010-02-28 13:49:32 From: Javier Morán \<jmoran@igalia.com> To: Manuel Rego Casasnovas \<rego@igalia.com> Version: navalplan-1.0 (1.0.x) Last updated: 2011-01-18 17:51:05

---

(Note: this issue was migrated automatically with bugzilla2github.py tool )

[kwoot]

Bugzilla Comment ID: 839 Date: 2010-02-28 14:00:26 From: Javier Morán \<jmoran@igalia.com>

In the predefined advances, now it is not possible to see the definition of the advance type. This must be corrected. The user must be able to see the definition of the predefined advance type althougth they cannot change it. Modify this.

[kwoot]

Bugzilla Comment ID: 838 Date: 2010-02-28 13:55:39 From: Javier Morán \<jmoran@igalia.com>

Modify the list of advance type in order to have a new column which shows if the advance type is predefined or defined by the user.

[kwoot]

Bugzilla Comment ID: 836 Date: 2010-02-28 13:49:32 From: Javier Morán \<jmoran@igalia.com>

When from the list of advances you try to delete an advance type exception happens when it has been asigned to any order element [1]. What it is needed to to is:

• Allow to delete if the advance type has not been asigned yet.
• Forbide the deletion if the advance type has already been asigned.

The confirmation pop-up has a bad UI style. Improve this too.

[kwoot]

Bugzilla Comment ID: 837 Date: 2010-02-28 13:50:20 From: Javier Morán \<jmoran@igalia.com>

[1] 4318960 [Thread-24] ERROR org.hibernate.util.JDBCExceptionReporter - ERROR: update o delete en una tabla "advancetype" viola la restriccion de clave foranea "fk808010cfb216ed4c" en la tabla "advanceassignment" Detail: La llave (id)=(150187) todavía es referida desde la tabla «advanceassignment». 4318961 [Thread-24] ERROR org.hibernate.event.def.AbstractFlushingEventListener - Could not synchronize database state with session org.hibernate.exception.ConstraintViolationException: could not delete: [org.navalplanner.business.advance.entities.AdvanceType#150187] at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:71) at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:43) at org.hibernate.persister.entity.AbstractEntityPersister.delete(AbstractEntityPersister.java:2536) at org.hibernate.persister.entity.AbstractEntityPersister.delete(AbstractEntityPersister.java:2692) at org.hibernate.action.EntityDeleteAction.execute(EntityDeleteAction.java:77) at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:279) at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:263) at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:172) at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:298) at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:27) at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1001) at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:339) at org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:106) at org.springframework.orm.hibernate3.HibernateTransactionManager.doCommit(HibernateTransactionManager.java:655) at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:732) at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:701) at org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:321) at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:116) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at $Proxy105.remove(Unknown Source) at org.navalplanner.web.advance.AdvanceTypeCRUDController.remove(AdvanceTypeCRUDController.java:202) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at bsh.Reflect.invokeMethod(Unknown Source) at bsh.Reflect.invokeObjectMethod(Unknown Source) at bsh.Name.invokeMethod(Unknown Source) at bsh.BSHMethodInvocation.eval(Unknown Source) at bsh.BSHPrimaryExpression.eval(Unknown Source) at bsh.BSHPrimaryExpression.eval(Unknown Source) at bsh.Interpreter.eval(Unknown Source) at bsh.Interpreter.eval(Unknown Source) at org.zkoss.zk.scripting.bsh.BSHInterpreter.exec(BSHInterpreter.java:119) at org.zkoss.zk.scripting.util.GenericInterpreter.interpret(GenericInterpreter.java:310) at org.zkoss.zk.ui.impl.PageImpl.interpret(PageImpl.java:787) at org.zkoss.zk.ui.impl.EventProcessor.process0(EventProcessor.java:176) at org.zkoss.zk.ui.impl.EventProcessor.process(EventProcessor.java:141) at org.zkoss.zk.ui.impl.EventProcessingThreadImpl.process0(EventProcessingThreadImpl.java:493) at org.zkoss.zk.ui.impl.EventProcessingThreadImpl.run(EventProcessingThreadImpl.java:425) Caused by: org.postgresql.util.PSQLException: ERROR: update o delete en una tabla "advancetype" viola la restriccion de clave foranea "fk808010cfb216ed4c" en la tabla "advanceassignment" Detail: La llave (id)=(150187) todavía es referida desde la tabla «advanceassignment». at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:1592) at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1327) at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:192) at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:451) at org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:350) at org.postgresql.jdbc2.AbstractJdbc2Statement.executeUpdate(AbstractJdbc2Statement.java:304) at org.hibernate.persister.entity.AbstractEntityPersister.delete(AbstractEntityPersister.java:2518) ... 38 more

[kwoot]

Bugzilla Comment ID: 856 Date: 2010-03-02 16:04:26 From: Manuel Rego Casasnovas \<rego@igalia.com>

commit 5386814c3bc6aa6ee5b599d93911bbb3ec7422f2 Author: Manuel Rego Casasnovas mrego@igalia.com Date: Tue Mar 2 16:02:52 2010 +0100

ItEr49S04ValidacionEProbasFuncionaisItEr48S04: [Bug #359] Fixed bug. Just allow to remove advance types not used.

commit fa98550af56614dd381a562186c2550158b98b7b Author: Manuel Rego Casasnovas mrego@igalia.com Date: Tue Mar 2 13:06:47 2010 +0100

ItEr49S04ValidacionEProbasFuncionaisItEr48S04: [Bug #359] Allowing see data of predefined (immutable) advance types.

commit 33fcc71b3fe4528f7183b3c8bff35dea6b272ac4 Author: Manuel Rego Casasnovas mrego@igalia.com Date: Tue Mar 2 12:58:20 2010 +0100

ItEr49S04ValidacionEProbasFuncionaisItEr48S04: [Bug #359] Removed unneeded buttons from zul of advance types list.

commit 9fec06465e8704186ec785e1f6c3adb05cb2e12d Author: Manuel Rego Casasnovas mrego@igalia.com Date: Tue Mar 2 12:56:36 2010 +0100

ItEr49S04ValidacionEProbasFuncionaisItEr48S04: [Bug #359] Adding new column "Predefined" to advance types list.