search

LibreQoE / LibreQoS

A Quality of Experience and Smart Queue Management system for ISPs. Leverage CAKE to improve network responsiveness, enforce bandwidth plans, and reduce bufferbloat.
https://libreqos.io/
GNU General Public License v2.0
464 stars 49 forks source link

Preflight bridge check #491

Closed thebracket closed 5 months ago

thebracket commented 6 months ago

Please test this (it's rebased to include the current develop) before we merge.

thebracket commented 5 months ago

Tests on local system (with veth devices) succeeds. With an XDP bridge enabled and a Linux bridge, it correctly disables the XDP one to avoid conflicts:

[2024-06-12T18:04:09Z INFO  lqosd::preflight_checks] Interface veth_toexternal is in status: UP
[2024-06-12T18:04:09Z INFO  lqosd::preflight_checks] Interface veth_tointernal is in status: UP
[2024-06-12T18:04:09Z ERROR lqosd::preflight_checks] Bridge (br0) contains both the internet and ISP interfaces, and you have the xdp_bridge enabled. This is not supported.
[2024-06-12T18:04:09Z WARN  lqosd::preflight_checks] Disabling XDP bridge
[2024-06-12T18:04:09Z WARN  lqosd::preflight_checks] XDP bridge disabled in ACTIVE config. Please fix the configuration file.
[2024-06-12T18:04:09Z INFO  lqosd::preflight_checks] Sanity checks passed

Without the bridge, it succeeds.

The interface state is informational only - it doesn't block success.

thebracket commented 5 months ago

It installed correctly on Payne, and ran there without issues also.