search

LibreQoE / LibreQoS

A Quality of Experience and Smart Queue Management system for ISPs. Leverage CAKE to improve network responsiveness, enforce bandwidth plans, and reduce bufferbloat.
https://libreqos.io/
GNU General Public License v2.0
464 stars 49 forks source link

build_rust.sh improvements for ubuntu 24.04 LTS #502

Closed interduo closed 5 months ago

interduo commented 5 months ago

Purpose of this change:

Checking that Rust is uptodate
./build_rust.sh: line 51: rustup: command not found
Please wait while the system is compiled. Service will not be interrupted during this stage.
./build_rust.sh: line 62: cargo: command not found
Cargo build failed. Exiting with code 1.

(full log at http://kłopotek.pl/libreqos-beta.txt)

thebracket commented 5 months ago

As I mentioned in the Zulip chat, I'm not approving anything that includes apt install rustup. That's a really busted way to install the Rust toolchain. Noticing that its not present, and directing the user to rustup.rs is fine - but not breaking the ability to ever update Rust properly again.

thebracket commented 5 months ago

The error you list shows that cargo wasn't installed. The real rustup installs that for you. It's an even worse idea to do apt install cargo, because Cargo is designed to be updated by rustup.

interduo commented 5 months ago

So merge it ;)

thebracket commented 5 months ago

I will in a moment. Merging before coffee is dangerous...

interduo commented 5 months ago

I will in a moment. Merging before coffee is dangerous...

Best wishes from "texas bar" in Poland. Messenger_creation_94e6ad0e-3de4-410c-a541-d8b966a47b5b.jpeg

thebracket commented 5 months ago

It's merged. :-)