search

LibreQoE / LibreQoS

A Quality of Experience and Smart Queue Management system for ISPs. Leverage CAKE to improve network responsiveness, enforce bandwidth plans, and reduce bufferbloat.
https://libreqos.io/
GNU General Public License v2.0
460 stars 49 forks source link

fix: removed doubled check "is lqosd running" #514

Closed interduo closed 4 months ago

interduo commented 4 months ago

When running ./LibreQoS.py --update-only there is a double check:

root@libreqos-beta:/opt/libreqos/src# ./LibreQoS.py --updateonly
Running Python Version 3.12.3 (main, Apr 10 2024, 05:33:47) [GCC 13.2.0]
lqosd is running
Configuration from /etc/lqos.conf is usable
lqosd is running
refreshShapers starting at 09/07/2024 09:12:18
Rust validated ShapedDevices.csv
ShapedDevices.csv passed validation
network.json passed validation
Observed no changes to ShapedDevices.csv or network.json. Leaving queues as is.
refreshShapersUpdateOnly completed on 09/07/2024 09:12:18

Please merge of if this is somehow intentional please move messages into function and leave is_lqosd_alive() only.

thebracket commented 4 months ago

I think this looks good? I'd appreciate a quick @rchac check before I merge this one.

thebracket commented 4 months ago

This looks good to me.

interduo commented 4 months ago

Thanks!