LibreQoE / LibreQoS

A Quality of Experience and Smart Queue Management system for ISPs. Leverage CAKE to improve network responsiveness, enforce bandwidth plans, and reduce bufferbloat.
https://libreqos.io/
GNU General Public License v2.0
460 stars 49 forks source link

Splynx Integration issue: A single Client with 2 services is added twice with both IP addresses each time. #541

Closed owaismai closed 3 weeks ago

owaismai commented 3 months ago

My env: libreqos version: 1.5 beta 2 Ubuntu 22.04

Issue: Splynx allows a single customer to have multiple internet services. Currently, when a single client has two services under it, both services are added twice with each IP address included both times in the shapeddevices.csv file. This results in duplicate entries with the same IP addresses listed In the examples below Jane Smith is one customer who has 2 services

| Circuit ID    | Client Name    | Device ID           | Device Name    | Parent Node          | MAC | IPv4                   | IPv6 | Download Min | Upload Min | Download Max | Upload Max |
|---------------|----------------|---------------------|----------------|----------------------|-----|------------------------|------|--------------|------------|--------------|------------|
| c_1959_s_9125 | John Brown     | c_1959_s_9125_d9125 | 9125           | 24_service20_ether4  |     | 10.100.8.159           |      | 49           | 49         | 50           | 50         |
| c_1989_s_3867 | Mike White     | c_1989_s_3867_d3867 | 3867           | 24_service24_ether3  |     | 10.100.8.1             |      | 49           | 49         | 50           | 50         |
| c_2013_s_3866 | Jane Smith     | c_2013_s_3866_d3866 | 3866           | 26_service4_vlan3004 |     | 10.100.8.140, 10.100.24.180 | 98           | 98         | 100          | 100        |
| c_2013_s_5450 | Jane Smith     | c_2013_s_5450_d5450 | 5450           | 26_service4_vlan3004 |     | 10.100.8.140, 10.100.24.180 | 98           | 98         | 100          | 100        |

Expected Behavior: The shapeddevices.csv file should show each service with its corresponding single IP address:

| Circuit ID    | Client Name    | Device ID           | Device Name    | Parent Node          | MAC | IPv4          | IPv6 | Download Min | Upload Min | Download Max | Upload Max |
|---------------|----------------|---------------------|----------------|----------------------|-----|---------------|------|--------------|------------|--------------|------------|
| c_1959_s_9125 | John Brown     | c_1959_s_9125_d9125 | 9125           | 24_service20_ether4  |     | 10.100.8.159  |      | 49           | 49         | 50           | 50         |
| c_1989_s_3867 | Mike White     | c_1989_s_3867_d3867 | 3867           | 24_service24_ether3  |     | 10.100.8.1    |      | 49           | 49         | 50           | 50         |
| c_2013_s_3866 | Jane Smith     | c_2013_s_3866_d3866 | 3866           | 26_service4_vlan3004 |     | 10.100.8.140  |      | 98           | 98         | 100          | 100        |
| c_2013_s_5450 | Jane Smith     | c_2013_s_5450_d5450 | 5450           | 26_service4_vlan3004 |     | 10.100.24.180 |      | 98           | 98         | 100          | 100        |
rchac commented 3 weeks ago

Fixed in v1.5-Beta3