search

LibreQoE / LibreQoS

A Quality of Experience and Smart Queue Management system for ISPs. Leverage CAKE to improve network responsiveness, enforce bandwidth plans, and reduce bufferbloat.
https://libreqos.io/
GNU General Public License v2.0
460 stars 49 forks source link

ISSUE #518 : Remove the "hot cache clear" call altogether, and instea… #545

Closed thebracket closed 3 months ago

thebracket commented 3 months ago

Remove the "hot cache clear" call altogether, and instead use a timeout/expiration to clear the cache gracefully. This allowed the map to be unpinned, and never accessed from userspace. Should fix the reload delays, and still give accurate mappings after a complete map rebuild.

interduo commented 3 months ago

I will test it on monday at about 11:00. Thanks for commit maybe after that I will be able to use new version :)

thebracket commented 3 months ago

I'm in favor of killing this PR, in favor of https://github.com/LibreQoE/LibreQoS/pull/547

interduo commented 3 months ago

ok so I did: git clone -b develop https://github.com/LibreQoE/LibreQoS cd LibreQoS git remote add interduo https://github.com/interduo/LibreQoS git fetch interduo git pull interduo patch-33 git cherry-pick e61b42b9cc42809f59c1009c7b27f38cf604cb5c cd src/rust/; cargo clean; cd ..; ./build_dpkg.sh dpkg -i dist/libreqos_1.5-BETA2.202408161104-1_amd64.deb

Testing on testbed2 (ubuntu22.04) show that reload is not hanging also like earlier PR.