LibreScore / dl-librescore

Download sheet music
MIT License
1.52k stars 52 forks source link

Download Buttons Stuck On Bottom Right Corner #3

Open poudink opened 2 years ago

poudink commented 2 years ago

The download buttons don't seem to appear correctly. They work, but they're totally stuck at the bottom right corner of the screen, constantly hiding that part and pretty inconvenient. I took the screenshot below with uBlock Origin and Dark Reader enabled, but this happens regardless of whether other extensions are enabled, so it can't be interference.

I've observed this issue with: Violentmonkey, Firefox, Linux Tampermonkey, Firefox, Linux Violentmonkey, Opera, Windows 7 Violentmonkey, Opera GX, Windows 10

I also tried Firemonkey and Greasemonkey just in case, but the userscript didn't work at all there.

I know for a fact this used to work fine a long time ago (it's probably been a couple of years at this point) and would place the download buttons below the Share/Add to set buttons. It just suddenly broke one day and I didn't think to open an issue until now. image

PeterNjeim commented 2 years ago

The reason they're anchored now is to avoid Musescore's detection. This has been the case for over a year now. It shouldn't block anything, sometimes there are even two scroll bars (if the browser width is small enough) to make sure you can reach everything you need.

PeterNjeim commented 2 years ago

If you mean you want a dark mode version of it to not blind your eyes (since dark reader can't do it as it's anchored and rendered after the initial page render), then I could probably do it at a later time

Xmader commented 1 year ago

it's anchored and rendered after the initial page render

There should be an easy fix. I've worked on it before, but I don't if anything changes.

DereC4 commented 1 year ago

In my opinion, an acceptable cosmetic loss for an awesome downloader!

DereC4 commented 1 year ago

I'm wondering how this would be fixed though; looks like right now it's more of an overlay in the user screen than embedded into site html