search

LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
650 stars 81 forks source link

"Pause in secure apps" - still can't touch the app! #139

Closed leoauri closed 6 years ago

leoauri commented 7 years ago

I have this new since 2.10.2

Often, the filter is deactivated as expected in secure app (owncloud, install app), but the app still doesn't respond to touch. Quite tricky to gain access to the app at all then!

I think it happened once after timer deactivation of the filter too, but I'm not completely sure how that went.

smichel17 commented 7 years ago

Could you try a build from master? If you can't build yourself, I periodically upload debug builds at http://smichel.me/files/red-moon/

Reason being, I refactored the code for turning the filter on and off to hopefully make this kind of error less common. Curious if I already caught this.

leoauri commented 7 years ago

OK, I've got 3.0.0-DEBUG running, I'll see how it goes...

smichel17 commented 7 years ago

👍 👎 ?

leoauri commented 7 years ago

It still happened.
I do have a hunch that it may have to do with #137, as the problem seems to occur when I have loaded more various apps during the night.
On my phone, if I load an app, switch to another, and switch back, it's in the same state; but if I load an app, switch to a lot of others and switch back some time later, the state is sometimes "forgotten" and the app reinitialised. I'm not sure but I think it may be related.

smichel17 commented 7 years ago

What you are describing is probably related to whether the UI is still in memory. You can encourage Android to remove it from memory by swiping it away from the recent apps screen, and by going to Settings > Developer option > running services > cached apps and removing it. Also, Settings > Developer option > Do not keep activities will have a similar effect (but may reduce your battery life).

What do you mean by "reinitialized"? Related to #131?

Generally the ui is all just settings. When it is reinitialized, it just restores from the settings as they were last time, so there should be nothing different, whether it was reinitialized or just loaded from memory.

smichel17 commented 7 years ago

@leoauri Latest commit cleaned up this section of the code so it may have fixed this. Or if it doesn't, it'll make debugging much easier :) Let me know if you get a chance to try it out. Related: #146

smichel17 commented 7 years ago

@leoauri I believe this issue had the same root cause as #142, which is fixed as of v3.1.0. When it shows up on F-Droid/GPlay (within the next few days. or you can build locally now), can you test to see if this bug remains?

leoauri commented 7 years ago

@smichel17 I will do so, thank you...

leoauri commented 7 years ago

Unfortunately 3.1.0 crashes upon trying to open the user interface...

smichel17 commented 7 years ago

It's actually on trying to restore the default profiles, which happens when upgrading or on first install. Fixed in master and v3.1.1, whenever F-Droid decides to update

smichel17 commented 6 years ago

v3.2.0 is released and should work. Let me know :)

leoauri commented 6 years ago

I have to admit I don't spend as much time in secure apps as I did (migrated to Nextcloud app), but so far this seems to be working perfectly.

smichel17 commented 6 years ago

Great :)

I'm not sure exactly whre the bug was, but it had to have been some time where we set the filter to be perfectly transparent, yet didn't actually remove it from the screen. Fixed by making it so those weren't separate actions -- now there's just one setColor() function, which checks if that color is transparent and removes the view from the screen if so.