search

LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
650 stars 81 forks source link

Give translators credit in the app #154

Closed smichel17 closed 6 years ago

smichel17 commented 7 years ago
mueller-ma commented 7 years ago

The app mysplash has a very beautiful about screen with small language flags, github avatars and when you tab on an name you get to the github page of this user

smichel17 commented 7 years ago

@mueller-ma Is that this? https://github.com/WangDaYeeeeee/Mysplash

mueller-ma commented 7 years ago

Yes

screenshot_20170909-202959
smichel17 commented 7 years ago

It looks nice. I'll take a look and see if I can easily re-use their code :)

smichel17 commented 7 years ago

Okay, I can't just copy-paste their code, since they're loading the avatars directly from github (red moon doesn't and never will request internet permission), and they use a lot of libraries that I don't want to introduce into red moon for something this simple.

I can re-use the layout itself, and just write my own code to set the images and text. That's a little more work so I probably won't do it today. For later: this is the relevant file.

mueller-ma commented 7 years ago

F-Droid might not like the profile pictures included, because they are not free.

smichel17 commented 7 years ago

Good point. An alternative is to ask you all what FLO image you'd like, and generate identicons for people who don't respond. Or use names and flags only.

comradekingu commented 7 years ago

If you make a field in the local branches of translation, wherein translators can add themselves along with a point of contact for corrections, no larger scale effort will have to take place.

smichel17 commented 7 years ago

If I do it that way, it'll be easier to support showing the main translator but harder to show a list of all translators. I suppose what people care about most is the person(s) who actually translated it into their language, so this is reasonable. I'll add the string.

mueller-ma commented 7 years ago

Think about other contributors. They are also important

smichel17 commented 7 years ago

Think about other contributors. They are also important

In Red Moon's specific case, the vast majority of contributions have been translations (@joonatoona with upcoming root mode support being the only major exception), so right now I'm primarily concerned with giving them credit.

Agreed that all contributors are important; I made the string a list, so anyone who translates can add their name. It's currently less prominent than I'd like; in the future, I'm interested in identifying the main contributor(s) for each language, like mysplash does. Currently my time is a bit limited, so this was an easy way to get everyone's name in quickly so I can give you all some of the credit you deserve right away.

Going forward I've started and will continue to give people credit in the changelogs as well, for whatever form of contribution.

comradekingu commented 7 years ago

If the string says "DO NOT TRANSLATE, READ: Add a list of current translators and past translators for the author field of the app, following this format. Name Surname email@domain.tld, Name2 Surname2 email2@domain.tld,"

smichel17 commented 7 years ago

author field of the app

I'm either unfamiliar with this feature or unsure of what you are suggesting. Could you clarify?

comradekingu commented 7 years ago

About/Contributions.

smichel17 commented 7 years ago

I'm still not quite sure I understand. The about screen doesn't really have an author section right now, unless the email field counts?

comradekingu commented 7 years ago

Right, but wherever this contact info/credit section would be put.

smichel17 commented 7 years ago

Yeah, it'd go on the about screen. Everything is build using preferences right now and I haven't tried dynamically generating them before, so it's a bit of extra work (which is why I went with the quick and easy translatable solution for now).

Just to confirm, you'd want your contact info in the app?

comradekingu commented 7 years ago

Yes, makes it easier to reach out in the event a mistake should have been made.

smichel17 commented 7 years ago

The alternative is: you could share emails privately with me and/or hang around in the chat room, and I can ping you there. I agree, it would also be nice if I had a reliable way to ping you all before I make a release.

smichel17 commented 7 years ago

For example, here there's a new string where you should not translate %on and %off, as those will be substituted with the on and off times, but I'm not sure how to communicate that to everyone.

comradekingu commented 7 years ago

You can have that explained in a string comment.

comradekingu commented 7 years ago

Looks like weblate has it all automated https://docs.weblate.org/en/latest/devel/reporting.html#translator-credits

smichel17 commented 6 years ago

You can have that explained in a string comment.

It used to be very easy to miss string comments in Weblate. However, it looks like they have changed their interface (now they display string comments very prominently), so this is a good option.

smichel17 commented 6 years ago

The original goal of this issue was included in v3.3.0, so I'm going to close this. I created #205 for the rest.