search

LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
647 stars 81 forks source link

System Brightness Integration #220

Closed AdamNiederer closed 6 years ago

AdamNiederer commented 6 years ago

Hey,

I use Lux to manage brightness on my AMOLED screen. My favorite part of Lux is its integration with system brightness - setting brightness below 0% activates and sets the overlay, while setting it to a positive number deactivates the overlay and sets system brightness accordingly.

Additionally, it's possible to change brightness from the persistent notification.

Would there be any interest in adding this to red-moon? I could probably lend a hand in implementing the lion's share of these features.

smichel17 commented 6 years ago

Yes, quite interested. The reason Red Moon doesn't currently work like that is a UX issue: say I use Red Moon to dim below the minimum, but then I use the normal system control to turn the brightness up. How should Red Moon react? How does Lux handle that case?

I'm going to close this in favor of #122, which already has probably-too-much discussion on the topic (feel free to skim instead of reading it all), so let's continue the conversation over there.

AdamNiederer commented 6 years ago

Ah, thank you. I didn't see that issue in my search.