LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
647 stars 81 forks source link

Port to Oreo #221

Closed AdamNiederer closed 6 years ago

AdamNiederer commented 6 years ago

Register a notification channel for the overlay notification, add a build flavor, and use newer versions of Gradle and build tools

Tested with a Nougat device and Oreo emulator

smichel17 commented 6 years ago

Thanks, I appreciate this! I have a really busy week right now so I probably won't find time to review this until next Monday or Tuesday.

AdamNiederer commented 6 years ago

No problem. I'll try to fiddle with Travis to make it build in the mean time.

smichel17 commented 6 years ago

Hi, sitting down to look at this now. While you're here, I'd appreciate if you have any feedback on your experience getting into the Red Moon code base.

Long-term, I'm interested in getting another maintainer (or few), to make sure the project doesn't die if something happens to my availability. That starts with people making small contributions, so I want to make that as easy as possible.

Thanks!

AdamNiederer commented 6 years ago

I've addressed each comment, and threw in a few boring IDE fixes. I just flashed my phone to Oreo, so I only tested 1537b7b on an Oreo device and Oreo emulator. You might want to squash the commits, because a few of them were just to push things through Travis.

smichel17 commented 6 years ago

Sorry this took so long to merge. I was going to clean up a few things, but then forgot. Figure I'll merge now and clean up after :)

I also added you as a collaborator for the repo, so you can make tweaks if you find something that's broken on Oreo (or elsewhere). Feel free to push directly or open PRs if you want me to look it over, first.

AdamNiederer commented 6 years ago

Thanks! I'm sure I'll be back with more.

smichel17 commented 6 years ago

I'll also add: I'm willing to walk you through the whole code base, if you're interested. It would probably get me back into working on Red Moon more, too :P