search

LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
647 stars 81 forks source link

Filter names don't change, when language changes #225

Open mueller-ma opened 5 years ago

mueller-ma commented 5 years ago

Steps to reproduce:

  1. Open and close the app
  2. Change system language
  3. Open the app again, the filter names are still in the previous language

"Restore default filters" changes the names to the second language.

smichel17 commented 5 years ago

It happens this way because the default filters are created/saved when you first open the app, and then loaded the same way as filters you create yourself.

I think using the "Restore default filters" menu option should overwrite the default filters with names in the new language. If I'm right about that, changing the language is a rare enough action, and the workaround is easy enough, that I probably won't do anything further. If I'm wrong, I'll change it to work like that.

There is a way to detect language changes, but I wouldn't want to recreate the filters just because you changed language (only rename), and the benefit to effort ratio of adding logic to rename them doesn't seem worth it (though I'd accept a patch for it).