search

LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
647 stars 81 forks source link

Toggle the filter without being able to see the screen #228

Closed smichel17 closed 4 years ago

smichel17 commented 5 years ago

From a Hacker News thread:

I'm a very happy red moon user. My main problem is that sometimes it is on or turns on by accident when I am outside and I don't manage to turn it off because I cannot see the screen. I would love to have a way to turn it off without needing to be able to see the screen, although I can't really think of a way that could be done...

I can think of two ways to do this:

  1. Act as an accessibility service and listen for certain hardware buttons (eg, volume up and down at the same time), like torchie. Probably the more reliable option, but requires extra permissions.
  2. Add some kind of gesture support. Requires minimal permissions, but might be more complicated to implement. Also need to avoid making it too easy to trigger accidentally.
smichel17 commented 4 years ago

I think the quick settings tile is probably the closest we will get to implementing this.

Red Moon is intended for night time use, so I don't want to complicate it to support daytime use. If Red Moon is turning on by accident during the day, then I would want to investigate why that is happening, first, and see if we can prevent it.

The other scenario where this can happen is if you set the schedule to sunset-to-sunrise and also use a filter that lowers system brightness. In this case, the brightness will be turned down too much. I suspect we can solve this with some combination of #33, #106, and #122.

I want to address those other issues first and then see if this is still an issue after that.
I am going to close this, but I'll leave the someday/maybe label on it to make it easier to find later.