search

LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
642 stars 80 forks source link

Screen navigation bar is not always filtered by Red Moon #252

Open grooku opened 5 years ago

grooku commented 5 years ago

Red Moon version: 3.4.0 Android version: 9 Device model: Samsung S10

The filter works perfectly fine when I have my phone in portrait mode. However, when I switch to landscape mode the navigation bar becomes unfiltered again. Portrait mode Landscape mode:

This issue happens when I start up Red Moon in landscape mode as well.

Thank you for making and working on this app!

Slion commented 4 years ago

I'm pretty sure I have a solution for that. I'll share a link once the code is online. Feel free to remind me if I forget about it.

smichel17 commented 4 years ago

Feel free to open a draft PR while you're working on it :)

Slion commented 4 years ago

I may let you guys do the work as I'm not much of a Red Moon user myself. However I dealt with that same problem for that project: https://github.com/Slion/FxService See home page there: https://slions.net/resources/fx-service.8/

I just forgot to push the last commit that was fixing that same issue. I'll push it later today when I fire up my computer.

Slion commented 4 years ago

Here is the commit which fixed that same issue: https://github.com/Slion/FxService/commit/e6258ca87d185d2668383c37325d606cb246872e Just take a look at the latest version of that file for a cleaner code.

The implementation is a bit funny because when trying to have something that made more sense it broke the nav bar again. However it looks like it works fine like this and that's fine by me :) Hope that helps.