Upgrade to SDK 29 - Githubissues

LibreShift / red-moon

Android screen filter app for night time phone use.

GNU General Public License v3.0

642 stars 80 forks source link

Upgrade to SDK 29 #260

Closed AdamNiederer closed 4 years ago

AdamNiederer commented 4 years ago

Supercedes #257

Jetpackifies the app via Android Studio's auto-migration
Migrates from the deprecated android.preferences libraries to androidx.preferences
Mildly refactors the TimePicker dialogue settings.

Tested on a real device running 8.1.0, and AVDs running 10.0, 8.0, 6.0, 5.1, 4.3, 4.1, and 4.0.

Resolves #242; Resolves #259

smichel17 commented 4 years ago

I haven't had a chance to test this (notably, my phone is still on 7.0 and I don't think expect it will ever receive an update). However, I skimmed the code a while back when you first opened it and nothing looked out of place. I think you should go ahead and merge it (and #256), and if there's any issues we can always fix them later.