I had enough niggles about the way the time picker currently works that I decided to just do a proper implementation.
[x] Read a lot of Android source code to understand how all this is handled
[x] Move preference to its own library and handle summary & updates in a robust way
[x] Replace simple TimePickerDialog call with a proper time picker dialog fragment
[ ] Clean up a few strings to use String.format instead of the ad-hoc substitution we're doing now :frowning_face:
None of the new strings are bad, so this shouldn't actually stop merging
[x] Add the option to set sunrise or sunset individually
[x] Allow setting a few of the options via xml
[ ] Move the library out of this repo and publish it separately (eg, to jcenter)
[ ] Adding some tests would probably be good. Alternatively, don't write any tests until there are bugs, and write exclusively regression tests along with the bugfixes. :joy:
I had enough niggles about the way the time picker currently works that I decided to just do a proper implementation.
TimePickerDialogcall with a proper time picker dialog fragment