LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
642 stars 80 forks source link

Support FireTV (/ AndroidTV?) input controls #282

Open andibuch opened 3 years ago

andibuch commented 3 years ago

Many of the controls are unusable from the FireTV, and I would assume the same to be true of other AndroidTV devices. Most problematically, these include:

The former: when you click on a slider, it highlights while you hold down the select button, and then goes back to normal when you let go. The left and right buttons have no effect whatsoever, whether they are used while hovering on the control or while holding the button down

The latter: when you pull up the clock input, it is set to 12:00 am. AM and PM can be switched, but the hour and minutes cannot be adjusted - clicking on them does not allow you to change the selected value on the clock face. Effectively, they can only be set to 12:00 AM and 12:00 PM, or left at their default values

SocietasEvanescentes commented 3 years ago

The latter: when you pull up the clock input, it is set to 12:00 am. AM and PM can be switched, but the hour and minutes cannot be adjusted - clicking on them does not allow you to change the selected value on the clock face. Effectively, they can only be set to 12:00 AM and 12:00 PM, or left at their default values.

Hey! I was able to set a custom time when I installed the app on my Fire TV Cube by going to the text field. Is your device not complying?

andibuch commented 3 years ago

Hey! I was able to set a custom time when I installed the app on my Fire TV Cube by going to the text field. Is your device not complying?

It is not, with the remote control at least

However, this helped me find a workaround: using the FireTV App on my phone, I can navigate to those fields and then type the values into them

It still doesn't work with the remote, and neither the remote or the app can make use of the sliders in order to set the color, opacity and darkness values - they are stuck at defaults

smichel17 commented 3 years ago

For anyone interested in trying to fix this, the slider preferences are a custom preference, it probably needs to be modified to respond properly to whatever signal is sent using the remote. That code is here: https://github.com/LibreShift/red-moon/blob/master/app/src/main/java/com/jmstudios/redmoon/preference/SeekBarPreference.kt

The time picker is also a custom preference; its code is here: https://github.com/LibreShift/red-moon/blob/master/timepickerpreference/src/main/java/org/libreshift/preferences/TimePreferenceDialogFragmentCompat.kt

adamkovari commented 2 years ago

@andibuch Hi, maybe it isn't an elegant solution, but it worked for me! :D https://www.firesticktricks.com/mouse-toggle-firestick.html