search

LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
642 stars 80 forks source link

(4 years late, but) Feature: Add root mode [#150] #287

Closed notjuliee closed 2 years ago

notjuliee commented 3 years ago

NOTE: The UX for this is still pretty janky, users with rooted phones will be asked for root upon the initial setup ending, which will show a "use root" option in the settings menu.

You must restart the app after toggling the "use root" option or things will not work properly

smichel17 commented 2 years ago

Good news and bad news.

The bad news is, when I tried this on the rooted phone today — Moto E4 (XT1524), Android 5.0, rooted with SuperSU — it zeroed out the backlight and I had to hold the power button to reboot into a good state. So we need some more experimentation, and probably a warning dialog.

The good news is, when I flashed LineageOS 17.1 and Magisk 23, it works like a charm. The other good news is now I'm familiar with the process of installing Magisk and flashing ROMs on this phone, so the annoying part is behind me and I can finally fix this up and get it merged.

smichel17 commented 2 years ago

I'm going to fix these post-merge, because it will be easier to merge #297 after this than vice versa, and I'd like to merge that PR so @bratyslav can work on other changes without having to do an annoying rebase.