search

LibreShift / red-moon

Android screen filter app for night time phone use.
GNU General Public License v3.0
642 stars 80 forks source link

Root mode follow-up #323

Closed smichel17 closed 1 year ago

smichel17 commented 1 year ago

This is a bunch of follow up from #150

I'd like to follow the same process I outlined in https://github.com/LibreShift/red-moon/pull/318#pullrequestreview-1024187396 for myself too, so I'd like a review before I merge this (whoever gets to it first :slightly_smiling_face:).

TODO:

smichel17 commented 1 year ago

Okay, tested on my device, seems to work as intended.

I think I'm going to skip my own ask and merge now, so I can go ahead and do the release, so I can check this item off my todo list. It would still be nice to get a retroactive review. the main motivation isn't to catch bugs or style issue, but to have more than one person familiar with the code, so I can be happy about continuing to step away from Red Moon development; this is the last major release I plan to do (I may still fix a few things here and there for my own usage).