Closed vitormattos closed 5 months ago
This release will close:
Great news. I can do some test if it helps.
Thanks a lot @tasagore ! The code follow unstable. I wish to launch a nightly release as pre-release when the code is more stable. Before, I will follow coding hardy every days as is possible to see looking the commits and PR's at repos of LibreSign organization here. Today I worked coding by 12 hours.
will this also include NC27 support ?
Only if we have funding to do this. At this time don't have a company or person helping the project to be maintained.
I published now the first release candidate compatible with Nexcloud 28.
https://github.com/LibreSign/libresign/releases/download/v8.0.0-rc1/libresign-v8.0.0-rc1.tar.gz
As a RC, could have a lot of problems, all help is welcome!
Hey @vitormattos I just tested 7.1.1 with NC 28.0.1 and the download binaries step failed. This is a feature that I could really use right now and would love to help test your RC. How would I go about trying to install it on my NC instance?
Hi @vitormattos
Thanks for the hard work! Unfortunately I don't have good news...
Tried to install in two different instances and unable to activate the application. One of them was an upgrade from 7.1.1 and have a lot of errors, the other one is a clean installation and show theses errors when I try to enable the app:
Upgrading from 7.1.1:
[PHP] Error: Undefined array key "file_user_id" at /var/www/html/portales/test/apps/libresign/lib/Migration/Version8000Date20230420125331.php#126
POST /test/index.php/settings/apps/enable
[index] Error: Object of class DateTime could not be converted to string in file '/var/www/html/portales/test/3rdparty/doctrine/dbal/src/Query/QueryBuilder.php' line 1432
POST /test/index.php/settings/apps/enable
Installing from scratch:
Exception":"Exception","Message":"Database error when running migration 8000Date20230420125331 for app libresign\nThere is no table with name \"nc_nextcloud.oc_libresign_file_user\" in the schema.","Code":0,"Trace":[{"file":"/var/www/html/portales/test/lib/private/Installer.php","line":155,"function":"migrate","class":"OC\\DB\\MigrationService","type":"->"}
Both seems problems with create/upgrade database schema, will take a look tomorrow deeply.
NC28 is one of the worst Nextcloud release plenty of bugs in the files app so probably we will have a long way to get a NC+Libresing stable configuration.
Hi @LeftoversTodayAppAdmin , the version 7.1.1 haven't support by Nextcloud 28, I ended its development. We are focused on version 28 which we released an RC last week https://github.com/LibreSign/libresign/releases/tag/v8.0.0-rc1
Hi @tasagore I identified your problem, I didn't made a backport of PR to stable28. I will do this and create a new RC.
Is necessary to apply this: https://github.com/LibreSign/libresign/pull/2277
Say hello to a new release candidate: https://github.com/LibreSign/libresign/releases/tag/v8.0.0-rc2
Hi @vitormattos
I've been able to install Rc2 in one one instance but still fails in the other, some problems with the database creation/upgradee.
The app seems to works but there are some problems with buttons and actions that doesn't work. I'm testing with a Mac+Safari and since NC28 has tons of bugs with scrollbars, buttons that don't work, web interface behavior...not sure if it's a Libresign problem or a NC problem. For example I can request (with some problems) a signature but when I try to sign the document I click in the "sign the document" button and nothing happens but as I said, since I've upgraded to NC28 this seems to be "normal". I only have two instances upgraded to NC28 just to test Libresing, all my other installations remains in NC27 since that version runs much fine.
Will take a look from Windows tomorrow, keep you in touch.
@tasagore could you provide more details about the problems related with database?
In your tests at browser, would be good open the developer tools and check if occur problems related to LibreSign.
@vitormattos Should I test RC7 on Nextcloud v28.0.2 or v28.0.3? Or does it matter?
Both
https://github.com/LibreSign/libresign/releases/download/v8.0.0-rc4/libresign-v8.0.0-rc7.tar.gz
Not found when I try to download it. I would like to test it also on v28.0.3
Thanks @glimz ! was a copy paste problem, sorry
First Random test:
I am not able to download binaries by clicking on Donwload Binaries
(Installed with occ
)
After uploading a doc, there is no preview (404)
There is an accountEmail
error when I add some users to a doc to sign (Emails are not fetched for those users I guess) first screenshot below
When trying to view the pdf
file with another account before signing, I cannot scroll down (PDF with 2 sheets)
After setting a password, I still get an error that password is wrong (could not sign the doc) with password set as way to identify a person who will sign a document.
If I change Ways to identify a person who will sign a document
to click to sign
, I am able to sign the doc
Please let me know if there is something specific you want me to test
Hi @glimz could you split your report in separated issues to be more easy to interact with each item? With all here will be very complex to reply and interact.
Hi @glimz could you split your report in separated issues to be more easy to interact with each item? With all here will be very complex to reply and interact.
It seems most of what I reported are known issues. Already reported, but I will create new issues for them.
Thanks! Will be good to have the issues because will be possible to me to identify the problem.
I'm also making a lot of tests and fixes but is very common to me to fix a problem without issue and only send the pull request with the fix.
Also occur scenarios that have small differences and I think that I solved a problem because a test scenario was fixed but could have a very similar scenario that have problems. This is very common to occur. Because this also is good to create issues detailing the steps to reproduce the problem because will be possible to check if my scenario is different of the scenario at issue.
@vitormattos Would you like me to create new issues found for V8.0.0 here or use the issue tracker which contains general bugs? I could create them here, one issue per comment, or create them in the issue tracker with V8.0.0 included in the header. I don't know which you will prefer?
After uploading a PDF, I get the errors (preview does not work)
Internal server error (422 error code), when trying to sign the document
@vitormattos Would you like me to create new issues found for V8.0.0 here or use the issue tracker which contains general bugs? I could create them here, one issue per comment, or create them in the issue tracker with V8.0.0 included in the header. I don't know which you will prefer?
@glimz I created this issue only to communicate that the development is going ahead even though the funding is not enough to pay even an engineer to work on the project, I have voluntarily dedicated a lot of effort to stop focusing on other activities that can give me some financial return so as not to let the LibreSign project stop as it is a project that I see which is very important to many people. And I also created more as an Epic of the release compatible with Nextcloud 28.
To report specific issues, will be good to do this in specific issues. By example, the problem that you talked about the previews. Having specific issues will be easy to don't lost nothing and isolate the talk about the issue in a specific place with the scenarios containing the steps to reproduce, details about environment,... You could get by example the newest issues created at this project and also the issue template that is displayed when you create a new issue.
@vitormattos Would you like me to create new issues found for V8.0.0 here or use the issue tracker which contains general bugs? I could create them here, one issue per comment, or create them in the issue tracker with V8.0.0 included in the header. I don't know which you will prefer?
@glimz I created this issue only to communicate that the development is going ahead even though the funding is not enough to pay even an engineer to work on the project, I have voluntarily dedicated a lot of effort to stop focusing on other activities that can give me some financial return so as not to let the LibreSign project stop as it is a project that I see which is very important to many people. And I also created more as an Epic of the release compatible with Nextcloud 28.
To report specific issues, will be good to do this in specific issues. By example, the problem that you talked about the previews. Having specific issues will be easy to don't lost nothing and isolate the talk about the issue in a specific place with the scenarios containing the steps to reproduce, details about environment,... You could get by example the newest issues created at this project and also the issue template that is displayed when you create a new issue.
Thank you for the clarification. I am also looking at creating some time to contribute with bug fixes. Since the test is done on this specific release compatible with 28
and it is not yet stable enough with no tags, I thought creating the bug here would be easier to track. From now on, I will create some each issue using the templates. Thanks for the good job you do
Now we have stable releases compatible with Nextcloud server 28 and 29!
It's the party time!
[!NOTE]
If you like this app, don't hesitate to help us
Ways to help this project:
- Creating a very nice review of this project at:
- social networks like LinkedIn, Instagram, etc and putting the @LibreSign and @LibreCodeCoop
- AlternativeTo https://alternativeto.net/software/libresign/
- Nextcloud apps store: https://apps.nextcloud.com/apps/libresign
- Sponsoring the development by GitHub sponsor https://github.com/sponsors/LibreSign
- helping the translations on Transifex
- contacting us to have Enterprise support: https://libresign.coop
Finally we stay at end of road to launch a new release of LibreSign.
During this time we made more than 1k of commits at the project to implement a lot of improvements. We made this by totally voluntary work without funding to maintain the project. Looking the dedicated time, was more than 1k of hours dedicated to this project during this period. But, the work never finish, we wish to create an excellent signature application and totally open source because we believe at open source community and at the cooperative work and we wish to always maintain the development of this project because we love open source.
To finish this round and launch the next release, we need:
Would be good put here the to-do list about next release.
A very, very big thanks for all that help the project interacting at issues, sending small code contributions and believing at this project.
ref: #1959
And,.... go ahead! Lets't go to next version! uhuuuuu!