search

LibreSign / libresign

✍️ Nextcloud app to sign PDF documents
https://libresign.coop
GNU Affero General Public License v3.0
472 stars 54 forks source link

Signature metadata not visible when validating a signature #2616

Open DazeEnd opened 5 months ago

DazeEnd commented 5 months ago

Describe the bug When the "Collect signers' metadata when signing a document" options is turned ON, the signature metadata is not displayed when validating a signature.

To Reproduce

  1. As admin, go to Settings > LibreSign > Collect signers' metadata, and turn ON the "Collect signers' metadata when signing a document" setting.
  2. Request a signature on a document of your choice.
  3. Sign the document from Step 2.
  4. As admin, open the LibreSign app, click on "Files" in the left sidebar, and then click on the signed document to open the right sidebar.
  5. In the right sidebar, click the "Validate" button.

Expected behavior Metadata for the signer should be displayed, including the browser user agent and the signer's IP address.

Actual behavior The signer's metadata is not displayed anywhere I can find. It does not appear in the validate screen, or in the validation information that is added to the footer of the document.

Screenshots LibreSign Settings: image Validation Screen: image Footer Validation Information: image Metadata Saved in Database: image

Environment information (please complete the following information):

Additional context The signer's metadata is being saved in the database. That metadata just isn't being displayed.

vitormattos commented 5 months ago

Changing from bug to feature.

vitormattos commented 5 months ago

For now is possible to use the app Analytics and create a report to return this data.

I wish to refactor the validation screen to provide these data.

Also have more data that is not visible for now at table sign_request related to notifications.

vitormattos commented 5 months ago

Is this issue duplicated of

?

DazeEnd commented 5 months ago

@vitormattos wrote:

Is this issue duplicated of #2617 ?

No, it is not. They are separate, but related issues.

This issue is reporting that signer metadata (browser user agent and IP address) do not seem to be visible anywhere in the UI, even when that data is collected. At the very least, I would expect this metadata to be visible when validating a signature through the LibreSign UI.

Issue #2617 is requesting a new feature -- a "signature information page". Even if you implemented issue #2617, I think this issue (#2616) would still need attention so that metadata could be added to the signature validation URL.

If I didn't explain the distinction well, please let me know and I can try to clarify again.

vitormattos commented 5 months ago

You are right.

This issue is more than to have a way to retrieve metadata, not what's the way, right?!