LibreSign / libresign

✍️ Nextcloud app to sign PDF documents
https://libresign.coop
GNU Affero General Public License v3.0
482 stars 56 forks source link

JS error "cannot read properties of null (reading 'uuid')" when open details of a file #3145

Open wmeneses opened 4 months ago

wmeneses commented 4 months ago

when I access through the libresign icon, the other icons in the bar disappear, when I click on the PDF the sidebar does not load and it is not possible to sign.

Enviroment:

ubuntu server Browser: any LibreSign Versión 8.0.2 Nextcloud 28.0.6 Logs (No log error from libresign)

libre

Environment information (please complete the following information):

wmeneses commented 4 months ago

It was working fine, (maybe it's cache).

vitormattos commented 4 months ago

Thanks a lot by your report

Have two types of pages at LibreSIgn:

  1. to authenticated accounts. This will display the menu bar
  2. Public pages, to signers that haven't account (signing by email by example) This page don't will display the menu bar

I need to make more tests to identify the cases that a link of public page is displayed to an authenticated account.

I already identified a moment:

This need to be fixed.

But could have other scenarios that reproduce the same behavior.

If possible to check what's the steps to reproduce your problem will be excellent to define a right title to this issue and to check if isn't the same scenario of issue #3133. Could you check this and return here with more details?

wmeneses commented 4 months ago

I am not sure, that it is the same case, it happens to me that simply the sidebar does not load anymore, generating that javascript error when I select the file to sign, the signing process seems to be correct. imagen_2024-06-13_131724312

vitormattos commented 4 months ago

I identified the points at RequestSignatureTab.vue that use the property uid I will review those pieces of code to verify what's happening. For now, I will rename this issue to be about this JS error because is the point that we identified.

wmeneses commented 4 months ago

Thank you very much, thank you guys for such a wonderful job. I hope you continue to improve it. I'll keep an eye on this error.

wmeneses commented 4 months ago

Hi, I have performed the same test, but with local users and it works fine.

I see what happens with my LDAP users

vitormattos commented 4 months ago

Good!

I will made a best check at the point of code that throws the error and keep in mind this information.

wmeneses commented 4 months ago

it seems to be with certain users, I have noticed that it may be because they delete the default folder (LibreSign) that is created in nextcloud, but if I try to create the same folder it still does not work, can it be that, is there a way to "clean" some registry in the user account?

wmeneses commented 4 months ago

Hi, I have tested this theory and indeed it is that I deleted the libresign folder of several users, because I changed the name from the configuration, I restored the folder and it worked again.

I do not know if this case can be closed, or if it is preferable that in the future this has a solution to prevent a user to do so and lose this functionality, something like "rebuild my signature folder".

Thanks!

vitormattos commented 4 months ago

If I understood, this problem occur after then you delete the LibreSign folder of an account that already signed a document using visible signature and using a certificate, right? And after then you restored the folder, the problem was solved.

wmeneses commented 4 months ago

If I understood, this problem occur after then you delete the LibreSign folder of an account that already signed a document using visible signature and using a certificate, right? And after then you restored the folder, the problem was solved.

Yes, it was solved by restoring the folders.

vitormattos commented 4 months ago

Let's maintain this open. Now we have a scenario to reproduce the problem.

I will check this.