On NC23 it does not seem to work at all ... cannot sign

[rotdrop]

Hi, thanks a log for sharing this app. However, I am not able to actually sign a single document. This is with the stable23 branch from GH.

What works:

• the app loads fine
• in the setting menu I can create signature and initials
• I can set the signing password, which also implies that the cfssl server is reachable
• I can choose files from the cloud and send out signature requests by email, also the files show up in the "pending" section in the LS-app

However, when I send hit the "sign" button in the app, nothing happens

Also when I click on the link in the email the following page appears in the web-browser with no signing button:

The "Send reminder" button works just fine.

[rotdrop]

In the web-browser's console I see debug messages

Ignoring invalid tab 
...
baseURI: "https://anaxagoras.home.claus-justus-heine.de/nextcloud-git/index.php/apps/libresign/f/timeline/sign"
​​```

[rotdrop]

Ok. Given that there are numerous commits between the v2.4.5 tag and the stable23 branch I assume that stable-branch is rather a development branch ... ;)

[vitormattos]

Hi @rotdrop! Thanks for your interaction and help!

About your question

You used the app from branch stable23 and did a build or installed from store? I believe that if you installed from store and do a refresh on page you will see the preview of PDF and I believe that we already identified this on main branch and fixed.

About branches

We did a lot of changes on code to implement visible signatures and now we need do adjusts on UX to launch the next release.

The development is on main branch, when a PR will be created, we make a backport to last LibreSign stable branches . Now, the last stable branches are stable23, stable22 and stable21. i.e.: on every PR created from any branches to main branch, if is necessary, after the code stay on main branch, we will create a backport to branch stable23, stable22 and stable21. When the release *.5.0 will finished we will generate 3 new releases to LibreSign: 23.5.0 to Nextcloud 23, 22.5.0 to Nextcloud 22 and 21.5.0 to Nextcloud 21.

Following with this way, we every will maintain the development of LibreSign compatible with the next version of server and will be possible maintain the stable releases to all Nextcloud stable releases.

The major number of LibreSign on the next version will follow the Nextcloud server major version.

[rotdrop]

Thank you! I had checked the stable23 branch after the installation from the store did not work. Also: PDF preview is not the problem. Its was just that the sign-button was dead. Anyhow, after struggling to find the correct JSignPdf version I have now a working setup with the app-version from the store.

[vitormattos]

Only one more consideration: all bugfixes need submitted to main branch and after the PR was merged to main, we will create a backport to stable branches.

[rotdrop]

Makes sense.

[rotdrop]

But then still: the git-branch "stable23" ATM does not work with the NC stable23 branch. I think there is an issue with the tabs-definitions of the right side-bar. At least the 2.4.5 version from the app-store works with NV v23 (after fingering out version of JSignPdf to use) and there is also a "sign" where in the stable23 branch there is only this "Validate File"-Button. And in the web-browser's console I find notifications about "Ignoring invalid tab" which originate from @nextcloud/vue. So the screen-shot below is from the 2.4.5 release from the app-store. The screen-shots in my other posts stem from the stable23 branch from the git-repo.

[rotdrop]

Ok, so last I think I understood your development policy: none of the branches is necessarily stable between releases and is in potentially not-working state (as is the case ATM). It is just that the stableXY branch is targeted towards the respective NC branch.

I'm closing this now. For the record: as far as I understand it signing does not work at the HEAD of all branches ATM, at least if it is meant as "signing using the web-ui". Defining signatures etc. OTOH does work, also placing the signature field on the PDFs.