LibreSolar / charge-controller-firmware

Firmware for Libre Solar MPPT/PWM charge controllers
https://libre.solar/charge-controller-firmware/
Apache License 2.0
144 stars 71 forks source link

Error flag ERR_LOAD_BUS_SRC_CURRENT never gets cleared #110

Closed martinjaeger closed 3 years ago

martinjaeger commented 3 years ago

Above mentioned error flag is set in load.cpp, e.g. if discharging is not allowed because of exceeded temperature limits. https://github.com/LibreSolar/charge-controller-firmware/blob/76ee3dc28ff0007ff973c9d782cada90117a9309/src/load.cpp#L66

However, it is currently never cleared (only after device reset), which does not make sense.

martinjaeger commented 3 years ago

Fixed in https://github.com/LibreSolar/charge-controller-firmware/commit/bdf405fb7b706e10f93faca311d3ac1791215daf