LibreSprite / Dotto

A portable and modern pixelart editor, written from scratch.
MIT License
692 stars 19 forks source link

Delete key on keyboard doesn't work when entering canvas size, and other keyboard shortcuts don't work #34

Closed mak448a closed 1 year ago

mak448a commented 1 year ago

Describe the bug A clear and concise description of what the bug is. When entering the canvas size, pressing the delete key on the keyboard doesn't delete the number in front of the cursor.

To Reproduce Steps to reproduce the behavior:

  1. Go to File
  2. Click on New
  3. Click on Width box
  4. Try putting the cursor one character back, then press the delete key on your keyboard

Expected behavior The delete key should delete the character in front of the cursor.

pixlxip commented 1 year ago

Also, end and home don't work. Home should bring you to the start, and end should bring you to the end, but neither work.

pegvin commented 1 year ago

it's not really a bug, instead the case isn't handled, in the implementation, only Arrow Left/Right & Backspace are handled, so keys like Delete, Home & End are not handled.

pegvin commented 1 year ago

@mak448a PR #38 fixed this issue, please test it again and close the issue if resolved.

felipemanga commented 1 year ago

Fix confirmed, closing.

mak448a commented 1 year ago

Thank you! It works!