search

LibreTexts / ckeditor-binder-plugin

A CKeditor plugin that makes adding binder enabled pre tags easy.
GNU General Public License v3.0
4 stars 2 forks source link

Fix for ipyleaflet #146

Closed TimStewartJ closed 3 years ago

TimStewartJ commented 3 years ago

Changes css rule for max-width for canvas objects to unset, fixes issue where ipyleaflet overlays wouldn't show.

Testing and comparison between the sandboxes on query (where ckeditor-binder-plugin uses ipyleaflet-fix branch) and chem shows no difference between the function of various plugins (with the exception of ipyleaflet of course).

Relevant to issue #107

moorepants commented 3 years ago

Ipycytoscape is not displaying (the canvas element) on query. Is that not effected perhaps?

TimStewartJ commented 3 years ago

I don't think the ipycytoscape issue is related, it also doesnt work on chem libretexts. I also tried using the web dev tools to manually change the canvas css properties for ipycytoscape and couldn't get it to work on either query or chem.

sandertyu commented 3 years ago

We thought we fixed ipycytoscape for jupyterlab 2 by pinning it to 1.0.4. This worked with our testing in Thebe originally, but now it doesn't work there either.

Regardless, this fix looks good. The example using the dynamic heatmap from my original issue work on query as well. Looks go to merge.